On 9/3/09 9:55, Guillaume Nodet wrote:
So I've changed fileinstall to optionally import the log service package
instead of exporting it.
Typically the only time you should export service API is if you are a
implementer, so I agree it doesn't make a lot of sense in this case.
I also have a local modification where I moved the classes in different
packages:
* interfaces that are currently in o.a.f.fileinstall.listener move to
o.a.f.fileinstall
* all other classes move to o.a.f.fileinstall.internal
* the bundle exports o.a.f.fileinstall package, but not the .internal one
which contain al the implementation classes
Sounds reasonable.
-> richard
I think this would be cleaner and more inlined with best practices.
Unless there's a problem with that, I'm planning to commit that change soon.
On Thu, Sep 3, 2009 at 10:32, Guillaume Nodet<gno...@gmail.com> wrote:
Btw, I also wonder about the need to export the
org.apache.felix.fileinstall package, as this one only contains
implementation classes and should be private imho. Have anyone seen a need
to really export this package ?
On Thu, Sep 3, 2009 at 10:29, Guillaume Nodet<gno...@gmail.com> wrote:
Fileinstall exports the org.osgi.service.cm and org.osgi.service.log
packages.
I wonder if this would make more sense to make them optional import and
make sure the code can run if those are not wired.
As a side effect would also reduce the size of the jar and simplify the
resolution process (I don't having having bundles exporting the same package
really helps ...)
Thoughts ?
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
