[
https://issues.apache.org/jira/browse/FELIX-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835677#action_12835677
]
Felix Meschberger edited comment on FELIX-1910 at 2/19/10 10:16 AM:
--------------------------------------------------------------------
Patch 16.license_plugin.patch [1] of FELIX-1988 includes a first step into this
direction, but there is a problem IMHO: The patch uses three request parameters
to select the license file to return:
bid -- bundle ID
url -- the license file to return
jar -- (optional) the path to an embedded library providing the license file
IMHO, this should all be encoded in the request URL, something like
http://..../licenses/<bundleId>/<path_to_jar>.jar/<path_to_file>
where the "<path_to_jar>.jar" part would be optional (and the .jar suffix could
be used as a match-marker
In addition, instead of sending back INTERNAL_SERVER_ERROR and FORBIDDEN, I
would just send back 404/NOT FOUND if the path is invalid or the file cannot be
resolved or an illegal file is requested.
[1]
https://issues.apache.org/jira/secure/attachment/12436299/16.license_plugin.patch
was (Author: fmeschbe):
Patch 16.license_plugin.patch [1] of FELIX-1988 includes a first step into
this direction, but there is a problem IMHO: The patch uses three request
parameters to select the license file to return:
bid -- bundle ID
url -- the license file to return
jar -- (optional) the path to an embedded library providing the license file
IMHO, this should all be encoded in the request URL, something like
http://..../licenses/<bundleId>/<path_to_jar>.jar/<path_to_file>
where the "<path_to_jar>.jar" part would be optional (and the .jar suffix could
be used as a match-marker
In addition, instead of sending back INTERNAL_SERVER_ERROR and FORBIDDEN, I
would just send back 404/NOT FOUND if the path is invalid or the file cannot be
resolved or an illegal file is requested.
> Normal URLs instead of Javascript links in Licenses screen
> ----------------------------------------------------------
>
> Key: FELIX-1910
> URL: https://issues.apache.org/jira/browse/FELIX-1910
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-1.2.10
> Reporter: Jukka Zitting
> Assignee: Felix Meschberger
>
> The Licenses screen in the Web Management Console uses links like
> javascript:displayBundle("123"); and javascript:displayFile("123", "Bundle
> Resources", "1"); which make it impossible to directly link to specific
> license information.
> It would be better if all the exposed information had a normal http URL like
> in the Bundles screen. In fact, how about if license information was included
> in the bundle information page at http://.../bundles/123?
> PS. Note that I'm looking at version 1.2.10 of the console, but since I
> didn't find relevant issues against more recent releases I believe this issue
> is still valid for the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
