On Sun, Feb 28, 2010 at 5:03 PM, Karl Pauls <karlpa...@gmail.com> wrote:
> -1 > > I'm really sorry but it looks to me like: > No reason to be sorry! Thats what this process is for! > org/apache/felix/karaf/deployer/features/FeatureURLHandler.java > org/apache/felix/karaf/shell/commands/EchoAction.java > I figured out that the rat profile we have in our builds uses a fairly old codehaus version of rat, and for whatever reason the new Apache incubator version makes these missing headers more obvious. I, like David, had run rat multiple times in the last week and not seen some of these hits (both of which have been in multiple previous releases just the way they are). > > are missing the license header and > > manual/pom.xml > client/dependency-reduced-pom.xml > dependency-reduced-pom.xml is a generated file so it should not have been in the distribution, but this may be related to the .asc.asc files. I can't remember, but its possible that I had to start the release build several times to fix issues and things didn't get properly cleaned in between. I've fixed the rat issue so that the missing headers show up more prominently and fixed the missing headers that we know about so I will cancel this release and start another after I review things a bit more. I think Guillaume and David have a good discussion going about the rest of these issues you bring up. > > are missing a header as well. Furthermore, > org.apache.felix.karaf.deployer.spring and a lot of the other modules > have dependencies on spring-core which is not mentioned in the notice > nor in the overall src notice (its mentioned in the overall binary > notice). > > Other findings (not show-stoppers) are: > > Signatures and checksums work for me but for some reason there are not > only .asc but .asc.asc and .asc.md5/sha and .asc.asc.md5/sha files > around. Very strange (probably something wrong with nexus/maven - not > sure we can do something about it). > > Other than that, it looks to me like you are only building the jars > and the sources jars but not the bin and project artifacts we usually > do. Not a problem as such (as you still have the sources for each > artifact) but its somewhat different from what we do normally ... > > Some artifacts are still using the osgi jars from felix (they should > switch to use the official org.osgi artifacts as soon as possible). > > regards, > > Karl > > > On Wed, Feb 24, 2010 at 7:57 PM, Chris Custine <ccust...@apache.org> > wrote: > > The Karaf 1.4.0 artifacts have been staged for release. > > > > These release artifacts contain updated copyright year in all NOTICE > files > > and includes an updated RELEASE-NOTES file which was not updated in the > > previous release vote. As requested by Richard, I have noted that the > vote > > will be open for *at least* 72 hours in order to allow time for proper > > review. > > > > Release notes are here: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310100&styleName=Html&version=12314410 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachefelix-015/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 015 /tmp/felix-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] -1 Veto the release (please provide specific comments) > > > > This vote will be open for at least 72 hours. > > > > > > -- > > Chris Custine > > FUSESource :: http://fusesource.com > > My Blog :: http://blog.organicelement.com > > Apache ServiceMix :: http://servicemix.apache.org > > Apache Felix :: http://felix.apache.org > > Apache Directory Server :: http://directory.apache.org > > > > > > -- > Karl Pauls > karlpa...@gmail.com >
