[ https://issues.apache.org/jira/browse/FELIX-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862256#action_12862256 ]
Christian Müller commented on FELIX-2280: ----------------------------------------- The property 'karaf.lock.jdbc.timeout' is never used by 'org.apache.felix.karaf.main.DefaultJDBCLock', 'org.apache.felix.karaf.main.MySQLJDBCLock' or 'org.apache.felix.karaf.main.OracleJDBCLock'. Because of lack of documentation, I assume that is the query timeout (statement.setQueryTimeout(timeout)) and not the login timeout (DriverManager.setLoginTimeout(timeout)). Please let me know, if I'm wrong so that I can change my work... > To much code duplication in DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLock > ----------------------------------------------------------------------------- > > Key: FELIX-2280 > URL: https://issues.apache.org/jira/browse/FELIX-2280 > Project: Felix > Issue Type: Improvement > Components: Karaf > Affects Versions: karaf-1.4.0 > Environment: All > Reporter: Christian Müller > Attachments: FELIX-2280.patch > > > org.apache.felix.karaf.main.DefaultJDBCLock, > org.apache.felix.karaf.main.MySQLJDBCLock and > org.apache.felix.karaf.main.OracleJDBCLock has to much code duplications. I > propose a solution like in ActiveMQ [package > org.apache.activemq.store.jdbc.adapter|http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/adapter/]. > And we should implement some unit tests for it. > If it's fine for you, I will try to improve this part of karaf and provide a > patch for it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.