[
https://issues.apache.org/jira/browse/FELIX-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862325#action_12862325
]
Jamie goodyear commented on FELIX-2280:
---------------------------------------
Regarding "OracleJDBCLock never checks in the alive method, if it holds the
lock ", that fix is waiting in a patch already :) --
https://issues.apache.org/jira/browse/FELIX-2130
I agree that the column names should be normalized across all implementation,
it's a bit of an artifact from the initial development run ;) Oracle held one
of the previous column names as a reserved word, so I just used another one
(definitely one of those refactor needed alarms going off there).
You will also notice that the different DBs will also display slightly
different lock behavior, this is undesirable but in some ways necessary due to
different locking mechanisms. Lets see what we can do to improve the
consistency here :)
In case you don't have access to an Oracle DB on hand may I suggest trying to
get a copy here:
http://www.oracle.com/technology/products/database/xe/index.html
One little gotcha when working with the Oracle DB is that the UNDO table space
can become over whelmed during use of long living locks, this accounts for some
of the major runtime behavior differences in how Oracle is treated.
Please keep the questions and patches coming, I'm more than happy to assist
where I can :)
> To much code duplication in DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLock
> -----------------------------------------------------------------------------
>
> Key: FELIX-2280
> URL: https://issues.apache.org/jira/browse/FELIX-2280
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Affects Versions: karaf-1.4.0
> Environment: All
> Reporter: Christian Müller
> Attachments: FELIX-2280.patch
>
>
> org.apache.felix.karaf.main.DefaultJDBCLock,
> org.apache.felix.karaf.main.MySQLJDBCLock and
> org.apache.felix.karaf.main.OracleJDBCLock has to much code duplications. I
> propose a solution like in ActiveMQ [package
> org.apache.activemq.store.jdbc.adapter|http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/adapter/].
> And we should implement some unit tests for it.
> If it's fine for you, I will try to improve this part of karaf and provide a
> patch for it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
