[
https://issues.apache.org/jira/browse/FELIX-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864442#action_12864442
]
Jamie goodyear commented on FELIX-2280:
---------------------------------------
Hi Christian,
I'm seeing some errors when I execute "mvn clean install" in karaf after I
applied your latest patch to my local checkout. It seems to repeatedly be
looking for the karaf log file and failing for each test case. Could you have a
quick look?
Cheers,
Jamie
Here is my environment setup in case I'm doing something wrong here:
jgood...@kang:~/x4/karaf/karaf$ mvn -version
Apache Maven 2.2.1 (r801777; 2009-08-06 16:46:01-0230)
Java version: 1.6.0_17
Java home: /opt/tools/jdk1.6.0_17/jre
Default locale: en_CA, platform encoding: UTF-8
OS name: "linux" version: "2.6.24-27-generic" arch: "amd64" Family: "unix"
{code}
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.felix.karaf.main.DefaultJDBCLockIntegrationTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.013 sec
Running org.apache.felix.karaf.main.DerbyJDBCLockIntegrationTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.005 sec
Running org.apache.felix.karaf.main.OracleJDBCLockIntegrationTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.005 sec
Running org.apache.felix.karaf.main.DefaultJDBCLockTest
java.io.FileNotFoundException: /data/log/karaf.log (No such file or directory)
at java.io.FileOutputStream.openAppend(Native Method)
at java.io.FileOutputStream.<init>(FileOutputStream.java:177)
at
org.apache.felix.karaf.main.BootstrapLogManager$SimpleFileHandler.open(BootstrapLogManager.java:106)
at
org.apache.felix.karaf.main.BootstrapLogManager$SimpleFileHandler.<init>(BootstrapLogManager.java:95)
at
org.apache.felix.karaf.main.BootstrapLogManager.getDefaultHandler(BootstrapLogManager.java:74)
at
org.apache.felix.karaf.main.DefaultJDBCLock.<init>(DefaultJDBCLock.java:66)
at
org.apache.felix.karaf.main.DefaultJDBCLockTest$2.<init>(DefaultJDBCLockTest.java:64)
at
org.apache.felix.karaf.main.DefaultJDBCLockTest.createConnectionShouldConcatinateOptionsCorrect(DefaultJDBCLockTest.java:64)
{code}
> To much code duplication in DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLock
> -----------------------------------------------------------------------------
>
> Key: FELIX-2280
> URL: https://issues.apache.org/jira/browse/FELIX-2280
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Affects Versions: karaf-1.4.0
> Environment: All
> Reporter: Christian Müller
> Attachments: FELIX-2280.patch, FELIX-2280.patch, FELIX-2280.patch
>
>
> org.apache.felix.karaf.main.DefaultJDBCLock,
> org.apache.felix.karaf.main.MySQLJDBCLock and
> org.apache.felix.karaf.main.OracleJDBCLock has to much code duplications. I
> propose a solution like in ActiveMQ [package
> org.apache.activemq.store.jdbc.adapter|http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/adapter/].
> And we should implement some unit tests for it.
> If it's fine for you, I will try to improve this part of karaf and provide a
> patch for it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
