On Thu, Jan 26, 2012 at 2:35 PM, Richard S. Hall <[email protected]> wrote: > On 1/26/12 8:09, Ken Gilmer wrote: >> >> Hi Richard, >> >> On Thu, Jan 26, 2012 at 9:32 PM, Richard S. Hall<[email protected]> >> wrote: >>> >>> The complete bundle includes OSGi classes, but does not list them in the >>> NOTICE file. It's not clear to me if this is a requirement, since they >>> OSGi >>> artifacts themselves don't include a NOTICE, but we generally do include >>> them in the NOTICE file for the framework JARs. >> >> In my memory I'd checked the http-bundle module and followed it but >> now that I check again I can see that it does in fact include the OSGi >> classes in the NOTICE. I can add that. >> >>> Also, I noticed that the DEPs file for the complete bundle was the old >>> format while the core bundle was auto-generated, was there a reason for >>> this? >> >> That is very strange. It took me a bit to figure out what you meant. >> On my local machine where I did the build the jars both contain the >> old format (meaning, not auto generated). But when I download the >> jars from the repo I can see that the complete bundle has the auto >> generated DEPENDENCIES file. I was under assumption that what I was >> building locally was what was being sent to the repo. > > > Yeah, I certainly don't know what's going on...I depend on Karl for > releasing stuff. ;-) > > The DEPs file stuff isn't so important anyway, I only mention for reasons of > consistency...my real question is about the NOTICE. If others think it isn't > important, then we are probably good to go.
I'd say it is up to the Release Manager (i.e., Ken in this case). The osgi jars don't contain a NOTICE so they don't have to be mentioned. I guess I just fix it in trunk and go ahead with the release unless it is easy for you to re-roll at this time. Just let us know what you want to do... regards, Karl > Thanks. > > -> richard > > >> >> thx >> ken >> >>> -> richard >>> >>> >>> On 1/20/12 0:57, Ken Gilmer wrote: >>>> >>>> Hello, >>>> >>>> We resolved 3 defects and added 3 features in this release: >>>> >>>> >>>> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+FELIX+AND+component+%3D+%22Lightweight+HTTP+Service%22+AND+status+%3D+Resolved+ORDER+BY+priority+DESC&mode=hide >>>> >>>> There are currently no outstanding issues. >>>> >>>> Staging repository: >>>> https://repository.apache.org/content/repositories/orgapachefelix-108/ >>>> >>>> You can use this UNIX script to download the release and verify the >>>> signatures: >>>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh >>>> >>>> Usage: >>>> sh check_staged_release.sh 108 /tmp/felix-staging >>>> >>>> Please vote to approve this release: >>>> >>>> [ ] +1 Approve the release >>>> [ ] -1 Veto the release (please provide specific comments) >>>> >>>> This vote will be open for 72 hours. -- Karl Pauls [email protected] http://twitter.com/karlpauls http://www.linkedin.com/in/karlpauls https://profiles.google.com/karlpauls
