Hi Arjun Cool. Will look into it ASAP.
Regards Felix Am 20.11.2012 um 11:47 schrieb Arjun Panday: > Hi Felix, > > I committed a fix yesterday. Indeed the code is much simpler, I got rid > of the extra servlet and I didn't even need to implement getResource > since you do that for me in SimpleWebConsolePlugin. > > Maybe you want to have a quick look and tell me if you think I missed > something? > > Should I close the JIRA once the commit is available in the trunk or > when the release is out? > > Thanks, > Arjun > > > Felix Meschberger wrote: >> Hi Arjun, >> >> Sounds great. If you need some more help, just get back to the list. >> >> Regards >> Felix >> >> Am 19.11.2012 um 11:29 schrieb Arjun Panday: >> >> >>> Thank you Felix, >>> >>> I'm afraid my integration with WebConsolePlugin dates a bit and I >>> probably already missed some points at the time. >>> I should probably try to fix this myself to update my understanding of >>> the webconsole! >>> >>> I was about to attempt a new release anyway. >>> >>> /Arjun >>> >>> >>> Felix Meschberger wrote: >>> >>>> Hi >>>> >>>> I tried to tackle FELIX-3764 [1] just to realize that this plugin IMHO is >>>> not properly integrated with the web console: >>>> >>>> * registers a /servicegraph/json servlet >>>> * registers /servicegraphe resources >>>> >>>> The problem with this is, that it doesn't account for non-root servlet >>>> contexts, is not integrated with the URL space and does not leverage the >>>> Web Console access control mechanisms. >>>> >>>> I suggest to change this plugin as follows: >>>> >>>> * Handle the .../json request as part of the WebConsolePlugin.service >>>> method >>>> * Implement a URL getResource [2] method in the WebConsolePlugin class >>>> >>>> This allows for full integration, leveraging access control and URL space >>>> integration plus also allows for using the appRoot and pluginRoot Web >>>> Console properties [3]. >>>> >>>> Does this make sense ? >>>> >>>> Regards >>>> Felix >>>> >>>> [1] https://issues.apache.org/jira/browse/FELIX-3764 >>>> [2] http://felix.apache.org/site/providing-resources.html >>>> [3] http://felix.apache.org/site/providing-web-console-plugins.html >>>> >> >> >
