On Tue, Dec 4, 2012 at 9:48 AM, Jan Willem Janssen < janwillem.jans...@luminis.eu> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 12/3/12 9:40 PM, Karl Pauls wrote: > > The "*-project.*" files have no top-level > > {notice,license,dependencies} files. They are in the archives but > > still under src/main/resources. > > > > The dependencies files list osgi provided files as being included > > but they are not. > > > > The notice file in the mongo db project list mongo db as a > > dependency. > > > > I think it is enough to fix the first two issues in trunk. > > I've created FELIX-3796 and FELIX-3797 for these issues. Ok and please go ahead and fix it in trunk directly too. > > In regard to the last one, why do you list mongo db as a dependency > > in the notice? > > I misread the sections on the contents of the NOTICE files; I was > under the assumption that it should include notices on all used > 3rd-party software. I now see that it should only contain notices on > those licenses that require this... > Yeah, that is what I figured. > In order to fix this, would it suffice to file a JIRA issue for this, > or does it have more severe implications for the release? Well, there are a lot of opinions around about this topic. We did this mistake in pretty much all of our early releases including quite some I did myself. Personally, I think in this case its ok to let it pass assuming it is fixed in trunk as we are talking about a micro version update release and the major version is suffering from the same problem. Ultimately, its up to you as the release manager assuming you have enough votes (which you have as long as nobody withdraws his vote because of it). regards, Karl > - -- > Met vriendelijke groeten | Kind regards > > Jan Willem Janssen | Software Architect > +31 631 765 814 > > /My world is:/ > > Luminis Technologies B.V. > IJsselburcht 3 > 6825 BS Arnhem > +31 88 586 46 30 > > http://www.luminis-technologies.com > http://www.luminis.eu > > KvK (CoC) 09 16 28 93 > BTW (VAT) NL8169.78.566.B.01 > -----BEGIN PGP SIGNATURE----- > Version: GnuPG/MacGPG2 v2.0.17 (Darwin) > Comment: GPGTools - http://gpgtools.org > Comment: Using GnuPG with undefined - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJQvbjcAAoJEKF/mP2eHDc4yCMQAIdhbacf6yJBK5HuC2wl3Ypu > Pe50Q5DFnlMzOFiUI/fR2oISZFhLdLCvH6iVthsAN1EsJ3cbynB5KUEctiFDPFNt > txllABqXIgOXorcFcWlW/5E+6k8JOIuhmHvxUzY1yvV9EtRx0zni7hovB9h35Z2J > rxY+3Isy9L3/66h0/En3Ow0ELew/f3El4JukMoL2oIEGGmib2nZmzPXhWQtFP3Hu > SrHOWYFL6SLr3dtg46XNiiCw2+2axNPIEUT2j60hv4ldkMKNTjqLnKNJZ2Fzzqiv > sPYx0maDYl+j+D3iw1eugovGOOfApuPQ/qCLsNodmya6kABKMgXy1HOBTuwHi517 > jO8wa0QwqK7weBL9Axai49sC/08mFFZNIUfZUFRuyPTc2ckiE1YgRf3q1LeXiKF0 > zz8gtNB7fkG3UDl0kJ5Ga5sD7bRqu5jVBRexhGabmZT2SB8Oq5ihE14zUrpBCyE+ > FpmgcVFTLRSGOcnSOE9JKA2TtFQnhYSz3Wnv2PMwskz2nsRT6K3l8ScXL1BlGTc7 > zt0hYkNll28NzHZpH62/jnEys4NmdewgNMLE7UXLrB3EzlfchIdSpkXwTqefztuP > 7dCCpz/aC+R8TxTejyrheztwSZWrL7GK7Nbq34sARMJmCkynWLL/Idb5azM+3N4f > uqMDG/Ija4EqOctS9fVA > =xwjf > -----END PGP SIGNATURE----- > > -- Karl Pauls karlpa...@gmail.com http://twitter.com/karlpauls http://www.linkedin.com/in/karlpauls https://profiles.google.com/karlpauls