On Tue, Dec 4, 2012 at 1:18 PM, Jan Willem Janssen < janwillem.jans...@luminis.eu> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 12/4/12 10:08 AM, Karl Pauls wrote: > >>>>> I've created FELIX-3796 and FELIX-3797 for these issues. > >>> > >>> > >>> Ok and please go ahead and fix it in trunk directly too. > > I've fixed these issues on the trunk. > > >>> > >>>>>> In regard to the last one, why do you list mongo db as a > >>>>>> dependency > >>>>>>> in the notice? > >>>>> > >>>>> I misread the sections on the contents of the NOTICE files; > >>>>> I was under the assumption that it should include notices > >>>>> on all used 3rd-party software. I now see that it should > >>>>> only contain notices on those licenses that require > >>>>> this... > >>>>> > >>> > >>> Yeah, that is what I figured. > >>> > >>> > >>>>> In order to fix this, would it suffice to file a JIRA issue > >>>>> for this, or does it have more severe implications for the > >>>>> release? > >>> > >>> > >>> Well, there are a lot of opinions around about this topic. We > >>> did this mistake in pretty much all of our early releases > >>> including quite some I did myself. Personally, I think in this > >>> case its ok to let it pass assuming it is fixed in trunk as we > >>> are talking about a micro version update release and the major > >>> version is suffering from the same problem. Ultimately, its up > >>> to you as the release manager assuming you have enough votes > >>> (which you have as long as nobody withdraws his vote because of > >>> it). > > I've created (and resolved) FELIX-3801, FELIX-3802 and FELIX-3804 for > this issue. > > Looks good to me. regards, Karl > > +1 (if the problems are fixed in trunk). > > - -- > Met vriendelijke groeten | Kind regards > > Jan Willem Janssen | Software Architect > +31 631 765 814 > > /My world is:/ > > Luminis Technologies B.V. > IJsselburcht 3 > 6825 BS Arnhem > +31 88 586 46 30 > > http://www.luminis-technologies.com > http://www.luminis.eu > > KvK (CoC) 09 16 28 93 > BTW (VAT) NL8169.78.566.B.01 > -----BEGIN PGP SIGNATURE----- > Version: GnuPG/MacGPG2 v2.0.17 (Darwin) > Comment: GPGTools - http://gpgtools.org > Comment: Using GnuPG with undefined - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJQveoQAAoJEKF/mP2eHDc4rHoP/0HvTeh8FQ0BN/mNW50Z+x0N > STh61alYuddT9rrVtv+vXOdiDAYB1eratsKytLvJ+/zz2NkzgmJApLz2qb+XX49t > rg1of2inGwKbCox7dEF5vbu144LNAodFCYo3Qka1HKcMGXOtkAYTgdhEy++8YtYk > BI9zuDWAaaoh8yFcDBUJzjgKIUoIb9kvQNemaGfOZ8Qs3PM1GHg+OKVZfX+oieT8 > iztc61Eq8ljm0So+Hy1yljxh8Ds0vRVDIu/XzEClU6PIT9tH6wY5/3TRkOXkGQby > klz5ebJJ376fkMOHT92JDMsqk8Jh55zycSiCs3dpK6VeX3ADjEHhZoXitmXAuBhM > IoS/F5U4+vPHnLLNV5yf2XzVhzPZte/kqJxPBaHCUSOaYuwr6F+Mz7gWvVTeB7y1 > lI246utHtzqJMVB83ytgYmr5M1v+N6+xIx4hqPtIgOcSuqVQlTutEtvmAg/fsCS/ > gFaQVaydk+wRqMD4PDxRzchMoAj8QoY7ohCNlmuwRMWYuROL7sOpedDWtQQhwDYy > Le8r60rn8eCAvZ3QrxBuxnn2zmuj/GiH7LYxuq3ZQq0K96hkymYoVmqUhcY6rNwG > 67mE31niPS46RTDjDkBExYgNPfylcCTwWa/Rpv45vKZ9BZ9mzNDVKd5sS5ew/+Lc > S3y8oA1tzrEjvuBLi4VV > =4U9K > -----END PGP SIGNATURE----- > > -- Karl Pauls karlpa...@gmail.com http://twitter.com/karlpauls http://www.linkedin.com/in/karlpauls https://profiles.google.com/karlpauls
