[ 
https://issues.apache.org/jira/browse/FELIX-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240546#comment-14240546
 ] 

Peter Kriens commented on FELIX-4720:
-------------------------------------

@Marcel: I disagree. The simplest solution is just to create an internal queue 
and fill it with the log history, whatever that is, and the just add the new 
events. This is a few lines of code and requires no special handling. KISS!

> Web Console and Gogo rely on Log history buffer in the Log Service
> ------------------------------------------------------------------
>
>                 Key: FELIX-4720
>                 URL: https://issues.apache.org/jira/browse/FELIX-4720
>             Project: Felix
>          Issue Type: Bug
>          Components: Gogo Command, Web Console
>            Reporter: Peter Kriens
>
> The OSGi Log Reader Service has a command to get the history of the log. 
> However, the specification states that this history can be empty. The Equinox 
> framework is nowadays registering a Log Reader Service that has such an empty 
> history to prevent pinning objects in memory. 
> Using the history this way was always at odds with the specification since 
> the history was only intended to hold the start up events. The primary model 
> of the Log Service is a dispatcher.
> I suggest that the Gogo log command and the Web Console maintain their own 
> history buffer to become independent on this fragile history buffer in the 
> Log Reader service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to