[
https://issues.apache.org/jira/browse/FELIX-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240770#comment-14240770
]
Felix Meschberger commented on FELIX-4720:
------------------------------------------
Somehow I have the impression, that yes, the Web Console (or Gogo for that
matter) should not do what [~pkriens] proposes because its none its/their
business.
On the other hand, from a practical and problem solving point of view, I agree
with Peter that these tools should go to some length to help solving problems.
I think the Web Console and Gogo stand special in the landscape of OSGi bundles
in that they are tools for application administrators. As such they should do
the best they can to support those (sometimes) poor guys.
So, yes, lets build a simple circular buffer of log messages in the Web Console
and Gogo:
* Create a new administrative log support bundle
* Inherit the LogServlet from Web Console core
* Inherit logging support commands from Gogo Command (Basic class)
* Dynamic package imports to Web Console and Gogo API (as needed)
* Can be deployed very early independently of Web Console proper and Gogo to
start collecting logs
* Maintains its own log entries which have weak references to the Throwables
* Gathers the entries in a circular buffer of configurable size
WDYT ?
> Web Console and Gogo rely on Log history buffer in the Log Service
> ------------------------------------------------------------------
>
> Key: FELIX-4720
> URL: https://issues.apache.org/jira/browse/FELIX-4720
> Project: Felix
> Issue Type: Bug
> Components: Gogo Command, Web Console
> Reporter: Peter Kriens
>
> The OSGi Log Reader Service has a command to get the history of the log.
> However, the specification states that this history can be empty. The Equinox
> framework is nowadays registering a Log Reader Service that has such an empty
> history to prevent pinning objects in memory.
> Using the history this way was always at odds with the specification since
> the history was only intended to hold the start up events. The primary model
> of the Log Service is a dispatcher.
> I suggest that the Gogo log command and the Web Console maintain their own
> history buffer to become independent on this fragile history buffer in the
> Log Reader service.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
