[
https://issues.apache.org/jira/browse/FELIX-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202969#comment-15202969
]
Anders Engström edited comment on FELIX-5219 at 3/19/16 9:08 PM:
-----------------------------------------------------------------
Hi -
in this case, personally, I think that explicit is better than implicit. I
believe that it's good to keep the original HttpServletRequest unmodified if
possible. Having an explicit "rule" in the Dispatcher for resolving requests
from "a proxy" will make the code more understandable.
In our setup we use the http.proxy and the http.bridge to implement 'pluggable'
REST services using https://github.com/hstaudacher/osgi-jax-rs-connector. The
Osgi JaxRS Connector uses Jersey internally which uses a bunch of magic tricks
to do its own HTTP routing. I _believe_ that keeping the HTTP request
consistent (not "hiding" the {{servletPath}}) will avoid issues there.
Fortunately it will be pretty straight forward for me to verify this :) I'll
try out your patch and let you know how it works!
was (Author: epirealer):
Hi -
in this case, personally, I think that explicit is better than implicit. I
believe that it's good to keep the original HttpServletRequest unmodified if
possible. Having an explicit "rule" in the Dispatcher for resolving requests
from "a proxy" will make the code more understandable.
In our setup we use the http.proxy and the http.bridge to implement 'pluggable'
REST services using https://github.com/hstaudacher/osgi-jax-rs-connector. The
Osgi JaxRS Connector uses Jersey internally which uses a bunch of magic tricks
to do its own HTTP routing. I *believe* that keeping the HTTP request
consistent (not "hiding" the {{servletPath}}) will avoid issues there.
Fortunately it will be pretty straight forward for me to verify this :) I'll
try out your patch and let you know how it works!
> Servlet Bridge does not work if not mounted as root servlet
> -----------------------------------------------------------
>
> Key: FELIX-5219
> URL: https://issues.apache.org/jira/browse/FELIX-5219
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
> Affects Versions: http.proxy-3.0.0, http.bridge-3.0.0, http.bridge-3.0.2,
> http.bridge-3.0.4, http.bridge-3.0.6
> Reporter: Anders Engström
> Assignee: Carsten Ziegeler
> Attachments: patch.txt
>
>
> As described in the email thread
> http://www.mail-archive.com/users%40felix.apache.org/msg17074.html -- the
> Http Servlet Proxy/Bridge does not work when binding the Proxy Servlet
> something else than {{/*}}.
> It seems that the bug was introduced in the 3.* versions - the proxy/bridge
> works as expected with version {{2.3.2}}.
> I've created a reference project at
> https://github.com/metamorph/http-osgi-bridge that demonstrates the bug.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
