[ 
https://issues.apache.org/jira/browse/FELIX-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206055#comment-15206055
 ] 

Anders Engström edited comment on FELIX-5219 at 3/22/16 9:57 AM:
-----------------------------------------------------------------

I've verified that my changes works as expected - but take into account that my 
branch also contains the original modification we talked about (explicitly *not 
using* the servletPath when calculating the path used to find a matching 
servlet ( 
https://github.com/metamorph/felix/blob/0625c38e572f02bfce42ae5ece5c3e9688c87a75/http/base/src/main/java/org/apache/felix/http/base/internal/dispatch/Dispatcher.java#L96
 ). That way the HandlerRepository can locate a matching servlet.

But - I'd also like to keep the changes in the ProxyServlet only. Your 
suggestion looks interesting.. given that the original request can be 
reconstructed using "contextPath + servletPath + pathInfo" I think it can work. 
We're basically just moving the original servletPath on top of the contextPath 
(if I understand you correctly).

I'll give it a spin! :)





was (Author: epirealer):
I've verified that it works as expected - but take into account that my branch 
also contains the original modification we talked about (explicitly *not using* 
the servletPath when calculating the path used to find a matching servlet ( 
https://github.com/metamorph/felix/blob/0625c38e572f02bfce42ae5ece5c3e9688c87a75/http/base/src/main/java/org/apache/felix/http/base/internal/dispatch/Dispatcher.java#L96
 ). That way the HandlerRepository can locate a matching servlet.

But - I'd also like to keep the changes in the ProxyServlet only. Your 
suggestion looks interesting.. given that the original request can be 
reconstructed using "contextPath + servletPath + pathInfo" I think it can work. 
We're basically just moving the original servletPath on top of the contextPath 
(if I understand you correctly).

I'll give it a spin! :)




> Servlet Bridge does not work if not mounted as root servlet
> -----------------------------------------------------------
>
>                 Key: FELIX-5219
>                 URL: https://issues.apache.org/jira/browse/FELIX-5219
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>    Affects Versions: http.proxy-3.0.0, http.bridge-3.0.0, http.bridge-3.0.2, 
> http.bridge-3.0.4, http.bridge-3.0.6
>            Reporter: Anders Engström
>            Assignee: Carsten Ziegeler
>         Attachments: patch.txt
>
>
> As described in the email thread 
> http://www.mail-archive.com/users%40felix.apache.org/msg17074.html -- the 
> Http Servlet Proxy/Bridge does not work when binding the Proxy Servlet 
> something else than {{/*}}.
> It seems that the bug was introduced in the 3.* versions - the proxy/bridge 
> works as expected with version {{2.3.2}}.
> I've created a reference project at 
> https://github.com/metamorph/http-osgi-bridge that demonstrates the bug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to