I much prefer we use the eclipse formatting template. I have that template setup for my workspace that I use for felix. I have also noticed the code gets formatted on save. Looking at my workspace settings it does seem this is enabled to format the code on save. I am unsure if I set that myself or of the act of importing the formatting template did it.
Tom. On Tue, Apr 25, 2017 at 11:09 AM, David Jencks <[email protected]> wrote: > Hi Christian, > > Felix has such an eclipse fomatting template, apparently my problem is > that I tried to use it. Perhaps it should be put in a more accessible > place? I think we should either use it or remove it, I’m a bit in favor of > using it. > > at the end of http://felix.apache.org/documentation/development/ > coding-standards.html there is a link to a template at > > https://issues.apache.org/jira/secure/attachment/ > 12419890/Apache+Felix+Eclipse+Template.xml which is the one I’ve been > using. > > There’s also https://issues.apache.org/jira/browse/FELIX-1406 which has > two attachments…. > > https://issues.apache.org/jira/secure/attachment/12419862/ > ApacheFelixEclipseTemplate.xml > https://issues.apache.org/jira/secure/attachment/12419890/Apache%20Felix% > 20Eclipse%20Template.xml (this is the one linked from the > coding-standards page) > > Reading the comments and checking links, I think that this issue has > resulted in the current target of the coding-standards page link being the > 2nd attachment to the issue. > > thanks > david jencks > > > > On Apr 24, 2017, at 11:43 PM, Christian Schneider < > [email protected]> wrote: > > > > Hi David, > > > > this might be an eclipse config. > > Open preferences and go to Java / Editor / Save Actions. > > There you can select to format the code on save of a file. > > Maybe this option is switched on for you. > > > > That said I think it would make sense to have a common formatter for the > code. In CXF we have checkstyle checks for the formatting as well > > as an eclipse formatter. It helps a lot to make sure that the code is > formatted in the same way by everyone and makes it easier to spot actual > changes. > > On the other hand the cxf formatting rules are a bit strange regarding > imports so without all the formatters installed it is a pain... So like > > most of the time it is a two edged sword ... > > > > Christian > > > > > > > > On 25.04.2017 03:51, David Jencks wrote: > >> For reasons unclear to me Eclipse has started saving modified files > reformatted with the felix eclipse code template. This, to put it mildly, > has shown that the code isn’t formatted with the template, and I can’t > fish out my actual changes by hand. > >> > >> What would people think if I reformatted the entire DS project and > checked in the result? I’m hoping that I can convince git to end up > showing me my actual changes after this exercise. > >> > >> In a somewhat separate issue, I have so far been unable to convince > Eclipse to let me open the R7 branch, so it’s possible someone else may > have to apply similar changes to that. > >> > >> thanks > >> david jencks > >> > > > > > > -- > > Christian Schneider > > http://www.liquid-reality.de > > > > Open Source Architect > > http://www.talend.com > > > >
