amitjoy commented on a change in pull request #11: [FELIX-6246] Packaged
External Library Packages inside referenced Health Check Bundles
URL: https://github.com/apache/felix-dev/pull/11#discussion_r399643937
##########
File path: healthcheck/core/bnd.bnd
##########
@@ -1,17 +1,8 @@
-Bundle-Category: healthcheck
-
-Bundle-Description: ${project.description}
-
-Bundle-DocURL: https://felix.apache.org
-
-Bundle-License: Apache License, Version 2.0
-
-Bundle-Vendor: The Apache Software Foundation
-
-Import-Package: org.quartz*;resolution:="optional", *
-
-Conditional-Package: org.apache.felix.utils.*
-
--removeheaders:\
- Include-Resource,\
- Private-Package
+Bundle-Category : healthcheck
+Bundle-Description : ${project.description}
+Bundle-DocURL : https://felix.apache.org
+Bundle-License : Apache License, Version 2.0
+Bundle-Vendor : The Apache Software Foundation
+Import-Package : org.quartz*;resolution:="optional", *
+-conditionalpackage : org.apache.felix.utils.*, org.apache.commons.lang3.*
Review comment:
I have also tested it yesterday and have noticed this discrepancy. The
internal references to other different packages lead to the inclusion of
several packages of org.apache.commons.lang3 which results to extra ~250KB in
respective bundles. For the time being, I would propose to leave it as it is
now. I will, in the meanwhile, think about it how we can trim down the
references. We can definitely reimplement the referenced static factories from
Apache Commons Lang3 once again that I tried too. But I feel it's rather
reinventing the wheel. I will think about some slim-down approaches and keep
you updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
