amitjoy commented on a change in pull request #11: [FELIX-6246] Packaged
External Library Packages inside referenced Health Check Bundles
URL: https://github.com/apache/felix-dev/pull/11#discussion_r399644330
##########
File path: healthcheck/generalchecks/bnd.bnd
##########
@@ -1,15 +1,11 @@
-Bundle-Category: healthcheck
-
-Bundle-Description: ${project.description}
-
-Bundle-DocURL: https://felix.apache.org
-
-Bundle-License: Apache License, Version 2.0
-
-Bundle-Vendor: The Apache Software Foundation
-
-Conditional-Package: org.apache.commons.cli.*,org.apache.felix.utils.*
-
-Export-Package: org.apache.felix.hc.generalchecks.util
-
-Import-Package: org.apache.felix.rootcause*;resolution:="optional", *
\ No newline at end of file
+Bundle-Category : healthcheck
+Bundle-Description : ${project.description}
+Bundle-DocURL : https://felix.apache.org
+Bundle-License : Apache License, Version 2.0
+Bundle-Vendor : The Apache Software Foundation
+Export-Package : org.apache.felix.hc.generalchecks.util
+Import-Package : org.apache.felix.rootcause*;resolution:="optional", *
+-conditionalpackage : \
+ org.apache.felix.utils.*,\
+ org.apache.commons.cli.*,\
+ org.apache.commons.lang3.*
Review comment:
Yeah, I agree completely with you. This results in extra ~250KB in the
respective bundles. I will think about some approaches that might help us trim
down the file sizes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
