tjwatson commented on a change in pull request #15: more flexible substrate
builder
URL: https://github.com/apache/felix-atomos/pull/15#discussion_r400358972
##########
File path:
atomos.maven/src/main/java/org/apache/felix/atomos/maven/AtomosIndexMojo.java
##########
@@ -63,7 +63,7 @@ public void execute() throws MojoExecutionException
AtomosIndexMojo::isJarFile).map(a ->
a.getFile().toPath()).collect(
Collectors.toList());
- SubstrateUtil.indexContent(paths, outputDirectory.toPath());
+ // SubstrateUtil.indexContent(paths,
outputDirectory.toPath());
Review comment:
I assume this still needs to be reworked to the refactored stuff. I have on
my list of things to do is add sniff integration tests to make sure the
examples still work. The atomos.examples.index resulting JAR no longer works
because the atomos index is no longer written.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
