tjwatson commented on a change in pull request #15: more flexible substrate
builder
URL: https://github.com/apache/felix-atomos/pull/15#discussion_r400366271
##########
File path:
atomos.maven/src/main/java/org/apache/felix/atomos/maven/NativeImageMojo.java
##########
@@ -109,78 +86,16 @@ public void execute() throws MojoExecutionException
try
{
Files.createDirectories(outputDirectory.toPath());
-
Config config = new Config();
-
config.additionalInitializeAtBuildTime =
additionalInitializeAtBuildTime;
- if (imageName == null || imageName.isEmpty())
Review comment:
I probably don't need to review this just yet. It seems the current state
is that the Mojos are not hooked into the utilities yet. The resulting build
of atomos.examples.substrate.maven.equinox doesn't produce a native-image yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
