glimmerveen commented on code in PR #486:
URL: https://github.com/apache/felix-dev/pull/486#discussion_r2984437417
##########
scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java:
##########
@@ -132,9 +133,12 @@ public class ComponentRegistry
private final ScheduledExecutorService m_componentActor;
+ private final UpdateChangeCountProperty m_updateChangeCountPropertyTask;
+
public ComponentRegistry(final ScrConfiguration scrConfiguration, final
ScrLogger logger, final ScheduledExecutorService componentActor )
{
m_configuration = scrConfiguration;
+ m_updateChangeCountPropertyTask = new
UpdateChangeCountProperty(m_configuration.serviceChangecountTimeout());
Review Comment:
Should a safe guard be implemented here to deal with a timeout of 0 being
configured? With the updated approach using a 'delay' of 0 does not when
calculating the maxNumberOfNoChanges nor using it as interval when scheduling a
task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
