tjwatson commented on code in PR #486:
URL: https://github.com/apache/felix-dev/pull/486#discussion_r2990828946


##########
scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java:
##########
@@ -132,9 +133,12 @@ public class ComponentRegistry
 
     private final ScheduledExecutorService m_componentActor;
 
+    private final UpdateChangeCountProperty m_updateChangeCountPropertyTask;
+
     public ComponentRegistry(final ScrConfiguration scrConfiguration, final 
ScrLogger logger, final ScheduledExecutorService componentActor )
     {
         m_configuration = scrConfiguration;
+        m_updateChangeCountPropertyTask = new 
UpdateChangeCountProperty(m_configuration.serviceChangecountTimeout());

Review Comment:
   Before your comment I went ahead and added a commit that set the min to 100. 
 It is a one-line constant change to make that be a min of 1 instead.  I would 
rather go with 100 for now and we can easily change it later if there is a need.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to