[
https://issues.apache.org/jira/browse/FINERACT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045398#comment-16045398
]
ASF GitHub Bot commented on FINERACT-241:
-----------------------------------------
Github user Ippezrobert commented on a diff in the pull request:
https://github.com/apache/fineract/pull/359#discussion_r121250008
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountReadPlatformServiceImpl.java
---
@@ -981,6 +983,12 @@ public SavingsAccountTransactionsMapper() {
sqlBuilder.append("left join m_account_transfer_transaction
totran on totran.to_savings_transaction_id = tr.id ");
sqlBuilder.append("left join m_payment_detail pd on
tr.payment_detail_id = pd.id ");
sqlBuilder.append("left join m_payment_type pt on
pd.payment_type_id = pt.id ");
+ sqlBuilder.append("left join m_appuser au on
au.id=tr.appuser_id ");
+ sqlBuilder.append("left join m_note mn on
mn.savings_account_id=sa.id ");
+ sqlBuilder.append("left join (");
+ sqlBuilder.append("select mn.savings_account_id id, mn.note
Note");
+ sqlBuilder.append(" from m_note mn ");
+ sqlBuilder.append(") comments ON
comments.id=tr.savings_account_id ");
--- End diff --
@nazeer1100126 , we didn't have the skype call but however i tried to work
things out. Then challenge i got is that the query is not joining the note with
the transaction id correctly. Please have a look at it here before i make
changes to send final PR. Thanks
What happens is that it repeats one note for all transactions not
particular to a transaction
> Include "Add Note" to Deposit and Withdrawal screen in savings account
> ----------------------------------------------------------------------
>
> Key: FINERACT-241
> URL: https://issues.apache.org/jira/browse/FINERACT-241
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Dayna Harp
> Assignee: Markus Geiss
> Labels: beginner, p3
>
> https://mifosforge.jira.com/browse/MIFOSX-2620
> Refer to MIFOSX for images
> Include "Add Note" to Deposit and Withdrawal screen in savings account so
> that narration can be added especially name of the person who has deposited
> which may not be necessarily the account holder. Its good for controls and
> follow ups.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
