[
https://issues.apache.org/jira/browse/FINERACT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085511#comment-16085511
]
ASF GitHub Bot commented on FINERACT-241:
-----------------------------------------
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/380#discussion_r127179728
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionDataValidator.java
---
@@ -94,6 +95,9 @@ public void validate(final JsonCommand command) {
final BigDecimal transactionAmount =
this.fromApiJsonHelper.extractBigDecimalWithLocaleNamed(transactionAmountParamName,
element);
baseDataValidator.reset().parameter(transactionAmountParamName).value(transactionAmount).notNull().positiveAmount();
+
+ final String note =
this.fromApiJsonHelper.extractStringNamed(noteParamName, element);
--- End diff --
Note can not be mandatory data. So ignore if it is null
> Include "Add Note" to Deposit and Withdrawal screen in savings account
> ----------------------------------------------------------------------
>
> Key: FINERACT-241
> URL: https://issues.apache.org/jira/browse/FINERACT-241
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Dayna Harp
> Assignee: Markus Geiss
> Labels: beginner, p3
>
> https://mifosforge.jira.com/browse/MIFOSX-2620
> Refer to MIFOSX for images
> Include "Add Note" to Deposit and Withdrawal screen in savings account so
> that narration can be added especially name of the person who has deposited
> which may not be necessarily the account holder. Its good for controls and
> follow ups.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
