On Mon, Jan 4, 2021 at 5:19 PM David Yahalomi <[email protected]> wrote:
> Hey Bharath, > > Thanks for the response. > > I've created this PR on our fork - > https://github.com/hypercore-ai/fineract/pull/10/files > > It enables the submission of historic rates with a flag on the floating > rate PUT request. > As you've mentioned, the actual work here is testing the effect of such a > change. > Do you know if the integration tests are currently testing the scenarios > you've specified? > David, if you raise a PR on https://github.com/apache/fineract/pulls, you'll quickly see if there is an IT test failure... ;-) don't be shy! You can mark such a PR as a "Draft" to signal to committers that "I don't need you to actually look at this for merging, just yet". > If not, we will soon manually test some of these cases. > > Best, > > David Yahalomi > Co-Founder > > Rothschild Blvd 3, Tel Aviv-Yafo, Israel > mobile: + 972 52 817 9787 > email: [email protected] > <https://articode.co> > > ᐧ > > On Mon, Jan 4, 2021 at 4:20 PM Bharath Gowda <[email protected]> wrote: > >> Hi David, >> >> Sounds interesting and a good feature to be unlocked, validation could be >> added either because of all the scenarios not tested yet, or there could be >> specific scenarios not handled at that time. >> >> We will have to test as much as scenarios as possible to check if there >> are any side effects >> >> Following are some important scenarios that could be tested >> 1. Rescheduling of loans and repay/undo repay scenarios. >> 2. Interest accruals behaviors on daily interest calculation >> configuration >> 3.Tranche loans scenarios >> 4.Penalty charge scenarios >> >> If things are still good, we could push the changes back to the upstream >> codebase, so that all the people of the community could be benifited from >> the feature. >> >> >> Regards, >> Bharath >> Lead Implementation Analyst | Mifos Initiative >> Skype: live:cbharath4| Mobile: +91.7019635592 >> http://mifos.org <http://facebook.com/mifos> >> <http://www.twitter.com/mifos> >> >> >> On Sun, Jan 3, 2021 at 9:34 PM David Yahalomi <[email protected]> wrote: >> >>> Hello all, >>> >>> In my current work with Fineract, I've noticed that there is a >>> constraint in Fineract that prohibits the submission of past periods. >>> >>> Does anyone know of a reason for that? >>> From my testing, after disabling this validation check, it seems that >>> the rest of the code handles that scenario quite well. Any loans with >>> interest re-calculation will be updated as it should. >>> >>> I'd love to hear your thoughts. >>> >>> Best, >>> >>> David Yahalomi >>> Co-Founder >>> >>> Rothschild Blvd 3, Tel Aviv-Yafo, Israel >>> mobile: + 972 52 817 9787 >>> email: [email protected] >>> <https://articode.co> >>> ᐧ >>> >>
