galovics commented on code in PR #2234:
URL: https://github.com/apache/fineract/pull/2234#discussion_r841437260
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1637,6 +1658,10 @@ private String
getUpdateSql(List<ResultsetColumnHeaderData> columnHeaders, final
}
}
sql += sqlGenerator.escape(key) + " = " + pValueWrite;
+ } else {
+ if (key.equalsIgnoreCase("updated_at")) {
Review Comment:
Magic string here.
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/api/DataTableApiConstant.java:
##########
@@ -34,4 +34,25 @@ private DataTableApiConstant() {
public static final String localParamName = "locale";
public static final String DATATABLE_RESOURCE_NAME = "dataTables";
+ public static final String createdAtFieldName = "created_at";
Review Comment:
This naming is not comforming the Java styling standards.
`
The names of variables declared class constants and of ANSI constants should
be all uppercase with words separated by underscores ("_"). (ANSI constants
should be avoided, for ease of debugging.)` -
https://www.oracle.com/java/technologies/javase/codeconventions-namingconventions.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
