+1 On Fri, Apr 8, 2022 at 4:06 PM Arnold Galovics <[email protected]> wrote:
> Hi guys, > > Just wanted to notify everybody, Lombok has landed on develop and already > showing a great deal of value in terms of reducing the boilerplate code. > > I touched some classes to kick-off the refactoring effort; you can find it > in this PR: https://github.com/apache/fineract/pull/2269 > > I'd like to take this as a chance to ask everybody to spend 5 more minutes > more on every PR you do and think about whether you can reduce some code > with Lombok around the places you touch; making the codebase more and more > maintainable. > Let's be good boy scouts. ;-) > > Let me know if you have questions. > > Best, > Arnold > > > > On Sat, Mar 19, 2022 at 10:27 AM Gerald O'Sullivan < > [email protected]> wrote: > >> Dear Friends >> >> Regarding the use of Lombok in Fineract, note that concerns have been >> raised about its use, and its compatibility (or lack of it) with JDK 16. >> See this post >> <https://www.reddit.com/r/java/comments/m66r8w/is_lombok_in_danger_of_becoming_incompatible_with/> >> or >> this article >> <https://levelup.gitconnected.com/be-careful-with-lombok-2e2edfc01110> >> for example. >> >> Personally, I avoid it to be on the safe side. Yes, it does reduce >> boilerplate, but that is not enough of a reason for me. Too much of the >> code disappears below the waterline for my liking. >> >> Note that I am NOT saying "don't use it", I am saying "approach with >> caution". >> >> Best >> Gerald >> >> On Thu, 17 Mar 2022 at 15:05, Avik Ganguly <[email protected]> wrote: >> >>> +1 >>> >>> On Wed, Mar 16, 2022 at 6:18 PM Arnold Galovics < >>> [email protected]> wrote: >>> >>>> Dear Community, >>>> >>>> While I've contributed to the codebase, I realized there's a lot of >>>> boilerplate code for a lot of classes. >>>> Mainly, I see the constructors which are really not doing anything >>>> except assigning parameters to fields + the @Autowired annotation. And we >>>> have a lot of getters/setters as well, mostly on DTOs. >>>> >>>> I don't have a number at hand but I think by using Lombok we could >>>> reduce the amount of boilerplate in the codebase considerably, I'm just not >>>> sure if somebody has considered it before. >>>> >>>> If there's no objection, I'd start introducing it gradually and then >>>> others could also benefit from it. >>>> >>>> Thoughts? >>>> >>>> Best, >>>> Arnold >>>> >>> >>> Disclaimer: >>> >>> Privileged & confidential information is contained in this message >>> (including all attachments). If you are not an intended recipient of this >>> message, please destroy this message immediately and kindly notify >>> the sender by reply e-mail. Any unauthorised use or dissemination of >>> this message in any manner whatsoever, in whole or in part, is strictly >>> prohibited. This e-mail, including all attachments hereto, (i) is for >>> discussion purposes only and shall not be deemed or construed to be a >>> professional opinion unless expressly stated otherwise, and (ii) is not >>> intended, written or sent to be used, and cannot and shall not be used, for >>> any unlawful purpose. This communication, including any attachments, may >>> not be free of viruses, interceptions or interference, and may not be >>> compatible with your systems. You should carry out your own virus checks >>> before opening any attachment to this e-mail. The sender of this e-mail and >>> *Fynarfin Tech Private Limited* shall not be liable for any damage that >>> you may sustain as a result of viruses, incompleteness of this message, a >>> delay in receipt of this message or computer problems experienced. >>> >> >> >> -- >> Gerald O'Sullivan >> Solution Architect >> Cellphone: +27 82 412 9962 >> >
