Yes, we have to be careful about removing things, that is probably an unspoken principle on this project as we don't know how it's being used. (unfortunately) However, if it makes sense from an architectural perspective to rationalize the notification and event handling frameworks, then I would suggest that we find a way to migrate this behavior. ... and wondering if this belongs in its own extension or outside component.
It may be "half-implemented" but that doesn't mean it isn't being used. ;) On Wed, May 18, 2022 at 7:43 AM Bharath Gowda <bgo...@mifos.org> wrote: > Hi Arnold, > > I have some organizations using the notification feature effectively for > sanctioning or disbursing the loan accounts based on the notifications > which they receive. It is mainly useful when there are different levels of > approvals for the loan cycle. > > (user configuration document for this feature is here > <https://docs.mifos.org/mifosx/user-manual/for-administrators-mifos-x-platform/configure-notifications> > ) > > Regards, > Bharath > Lead Implementation Analyst | Mifos Initiative > Skype: live:cbharath4| Mobile: +91.7019635592 > http://mifos.org <http://facebook.com/mifos> > <http://www.twitter.com/mifos> > > > On Wed, May 18, 2022 at 3:29 PM Aleksandar Vidakovic < > chee...@monkeysintown.com> wrote: > >> ... thanks Adam... learned again. >> >> On Wed, May 18, 2022 at 10:28 AM Ádám Sághy <adamsa...@gmail.com> wrote: >> >>> Hi guys, >>> >>> So lets see what i know about this functionality: >>> >>> - The Fineract is the publisher and also a listener for the Notification >>> events. >>> >>> - Fineract is publishing notifications in the following situations: >>> "ACTIVATE_CLIENT" >>> "ACTIVATE_CENTER" >>> "ACTIVATE_GROUP" >>> "READ_SAVINGSACCOUNT" >>> "READ_DIVIDEND_SHAREPRODUCT" >>> "APPROVE_FIXEDDEPOSITACCOUNT" >>> "APPROVE_RECURRINGDEPOSITACCOUNT" >>> "ACTIVATE_FIXEDDEPOSITACCOUNT" >>> "ACTIVATE_RECURRINGDEPOSITACCOUNT >>> "ACTIVATE_SAVINGSACCOUNT" >>> "READ_SAVINGSACCOUNT" >>> "APPROVE_LOAN", >>> "DISBURSE_LOAN" >>> "READ_LOAN" >>> "READ_Rescheduled Loans" >>> "READ_LOAN" >>> "READ_LOANPRODUCT" >>> "APPROVE_SAVINGSACCOUNT" >>> "READ_SAVINGSACCOUNT" >>> "APPROVE_SHAREACCOUNT" >>> “ACTIVATE_SHAREACCOUNT” >>> >>> - There is a topic subsciption functionality also where appusers can >>> subscribe for events and they got notified when that event occured. >>> - When a user is created based on the roles, the fineract might >>> subscribe automatically for topics >>> >>> - Fineract listener are listening for these kind of events and when it >>> happens it will create a notification entry into the database for the >>> subscribed users. >>> - When a subscribed user logs into the Fineract, they will get the >>> notification (on the UI for example a popup). >>> >>> I hope it helps to visualize this functionality a little bit better and >>> decide on its future. >>> >>> Regards, >>> Adam >>> >>> On 18 May 2022, at 09:56, Aleksandar Vidakovic < >>> chee...@monkeysintown.com> wrote: >>> >>> ... other question: does it do anything? I'll have another look at it >>> today, but it seems non-functional. >>> >>> It's going to be hard to reach in general a consensus if people are not >>> participating... same argument could be made for introducing Liquibase; I'm >>> sure that others invested time in Flyway, but we still replaced it. >>> >>> Just my 2 cents. >>> >>> On Wed, May 18, 2022 at 9:43 AM Awasum Yannick <awa...@apache.org> >>> wrote: >>> >>>> Hello Aleks and Arnold, >>>> >>>> I won't remove that feature given we don't know who may or may not be >>>> using it. >>>> >>>> There are people using Fineract who are not even on this dev list or >>>> participating in conversations. >>>> >>>> I would be careful with what I remove even if it looks unusable to me. >>>> >>>> On Wed, May 18, 2022, 02:11 Aleksandar Vidakovic < >>>> chee...@monkeysintown.com> wrote: >>>> >>>>> I would say: +1 >>>>> >>>>> On Tue, May 17, 2022 at 10:01 PM Arnold Galovics <arn...@apache.org> >>>>> wrote: >>>>> >>>>>> Hi guys, >>>>>> >>>>>> I'm exploring the current event handling frameworks available in >>>>>> Fineract - Hooks, Business events and Notification events - and I was >>>>>> wondering if anybody is using the so called "topic subscriptions" in >>>>>> Fineract within the Notification events module. >>>>>> >>>>>> As far as I can tell, it's a half-complete implementation but I see >>>>>> that upon creating a new user and assigning it to an office, it >>>>>> automatically subscribes the user to a particular topic but the notion of >>>>>> "subscribing to a topic" doesn't really have any meaning at this point. >>>>>> >>>>>> If nobody is using the feature, I'll just remove it to get rid of >>>>>> some of the weight we've been carrying. >>>>>> >>>>>> Let me know. >>>>>> >>>>>> Best, >>>>>> Arnold >>>>>> >>>>> >>>
