Hi From Adam Monen’s mail:
"Integration and e2e tests do not pass. I recall 1.10.1 (commit 227bdf6e4f) also had an issue with asciidoctor so I didn't try building the docs.” These does not sounds good to me! Should we double check what are the issues and fix them first? Regards, Adam > On 19 Dec 2024, at 17:34, James Dailey <[email protected]> wrote: > > +1 Binding > > As release manager I did the build (back in August) and verified the PGP > keys. > I have not done any functional or regression testing; I am trusting the > process of PR acceptance. > > Thank you Aleks for making the release artifacts. > > VOTE is open for a little longer. > > > > > > > On Thu, Dec 19, 2024 at 7:31 AM Adam Monsen <[email protected] > <mailto:[email protected]>> wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA512 >> >> >> >> +1 >> >> >> I'm able to download all artifacts. Checksums pass and PGP signatures >> are valid. The source builds: `./gradlew :fineract-war:war` succeeds. >> The first step of `./gradlew test` works (unit tests, I guess). >> Integration and e2e tests do not pass. I recall 1.10.1 (commit >> 227bdf6e4f) also had an issue with asciidoctor so I didn't try building >> the docs. >> >> - -Adam >> >> >> -----BEGIN PGP SIGNATURE----- >> >> iQEzBAEBCgAdFiEE2AAt8o4AsOdm9pv4m12ZP4NvKcAFAmdkO8kACgkQm12ZP4Nv >> KcBsXgf+MEMSZdjVlGKSXprWsDrKbIXngRvBb2CtmcUh/xuqdqiT3mN+XNiNRWjr >> NKIu+/hemL6nkIVu16XiR8YUNmgg3N0KRXcALb1zcw89VqlZHXTcBmQxg/G7Og5K >> oRZQbaxNZOcwQAb2b1GK7w2ATA4apOhQqtDXdHmeVIWhWEzdBOV0nXRqQCkyNp98 >> cGqYxE90JnYCzRZO80wGH0qqeZvFBJ0lXASIzD+t0hXYUcC4Q+jnHMXo8ukl5/R7 >> hCtB7LIc7Ijh8LcQaDLYdCZGduZBGt1yE7Uqp0qmo1Mt5jBlnzSF4OvXatsD50nd >> z6KV1YIgWwXTyMn0SbOkwpYBXBT4kA== >> =kiPB >> -----END PGP SIGNATURE-----
