+1 binding I downloaded the source and built the binaries from it. Fineract started without issues and no problems encountered in the simple sanity testing. Same with the binaries provided.
Then ran integration and e2e tests, and these worked fine for me. The only tests that did not work were the oauth2 ones as the local Cargo instance would not start. But I think that’s because of something flaky with my development environment. fineract-doc and AsciiDoctor has been commented out from all the build scripts, so I’m assuming it should not work. Also just an observation that the distributed source jar contains a number of (mainly empty) paths under “custom” that are not there in our repository: 8 custom/monkeysintown/accounting/api/build/libs 8 custom/monkeysintown/accounting/api/build/tmp/jar 8 custom/monkeysintown/accounting/api/build/tmp 16 custom/monkeysintown/accounting/api/build 16 custom/monkeysintown/accounting/api 8 custom/monkeysintown/accounting/service/build/libs 8 custom/monkeysintown/accounting/service/build/tmp/jar 8 custom/monkeysintown/accounting/service/build/tmp 16 custom/monkeysintown/accounting/service/build 16 custom/monkeysintown/accounting/service 32 custom/monkeysintown/accounting 0 custom/monkeysintown/loan 32 custom/monkeysintown 0 custom/common 0 custom/suplus/loan/api/src/main/java/io/fiter/fineract/suplus/loan/api 0 custom/suplus/loan/api/src/main/java/io/fiter/fineract/suplus/loan 0 custom/suplus/loan/api/src/main/java/io/fiter/fineract/suplus 0 custom/suplus/loan/api/src/main/java/io/fiter/fineract 0 custom/suplus/loan/api/src/main/java/io/fiter 0 custom/suplus/loan/api/src/main/java/io 0 custom/suplus/loan/api/src/main/java 0 custom/suplus/loan/api/src/main 0 custom/suplus/loan/api/src 0 custom/suplus/loan/api 0 custom/suplus/loan/service/src/main/java/io/fiter/fineract/suplus/loan/service 0 custom/suplus/loan/service/src/main/java/io/fiter/fineract/suplus/loan 0 custom/suplus/loan/service/src/main/java/io/fiter/fineract/suplus 0 custom/suplus/loan/service/src/main/java/io/fiter/fineract 0 custom/suplus/loan/service/src/main/java/io/fiter 0 custom/suplus/loan/service/src/main/java/io 0 custom/suplus/loan/service/src/main/java 0 custom/suplus/loan/service/src/main 0 custom/suplus/loan/service/src 0 custom/suplus/loan/service 0 custom/suplus/loan 0 custom/suplus > On 20 Dec 2024, at 10:04 PM, James Dailey <jamespdai...@gmail.com> wrote: > > Well. Adam M also voted +1 so I took I to mean it was of minor inconvenience. > > > If people want to retract votes , ok , otherwise I’m assuming the tests were > broken and we should proceed anyway. > > Sent from Gmail Mobile > > > On Fri, Dec 20, 2024 at 2:53 AM Ádám Sághy <adamsa...@gmail.com > <mailto:adamsa...@gmail.com>> wrote: >> Hi >> >> From Adam Monen’s mail: >> >> "Integration and e2e tests do not pass. I recall 1.10.1 (commit >> 227bdf6e4f) also had an issue with asciidoctor so I didn't try building >> the docs.” >> >> These does not sounds good to me! Should we double check what are the issues >> and fix them first? >> >> Regards, >> Adam >> >>> On 19 Dec 2024, at 17:34, James Dailey <jamespdai...@gmail.com >>> <mailto:jamespdai...@gmail.com>> wrote: >>> >>> +1 Binding >>> >>> As release manager I did the build (back in August) and verified the PGP >>> keys. >>> I have not done any functional or regression testing; I am trusting the >>> process of PR acceptance. >>> >>> Thank you Aleks for making the release artifacts. >>> >>> VOTE is open for a little longer. >>> >>> >>> >>> >>> >>> >>> On Thu, Dec 19, 2024 at 7:31 AM Adam Monsen <amon...@mifos.org >>> <mailto:amon...@mifos.org>> wrote: >>>> -----BEGIN PGP SIGNED MESSAGE----- >>>> Hash: SHA512 >>>> >>>> >>>> >>>> +1 >>>> >>>> >>>> I'm able to download all artifacts. Checksums pass and PGP signatures >>>> are valid. The source builds: `./gradlew :fineract-war:war` succeeds. >>>> The first step of `./gradlew test` works (unit tests, I guess). >>>> Integration and e2e tests do not pass. I recall 1.10.1 (commit >>>> 227bdf6e4f) also had an issue with asciidoctor so I didn't try building >>>> the docs. >>>> >>>> - -Adam >>>> >>>> >>>> -----BEGIN PGP SIGNATURE----- >>>> >>>> iQEzBAEBCgAdFiEE2AAt8o4AsOdm9pv4m12ZP4NvKcAFAmdkO8kACgkQm12ZP4Nv >>>> KcBsXgf+MEMSZdjVlGKSXprWsDrKbIXngRvBb2CtmcUh/xuqdqiT3mN+XNiNRWjr >>>> NKIu+/hemL6nkIVu16XiR8YUNmgg3N0KRXcALb1zcw89VqlZHXTcBmQxg/G7Og5K >>>> oRZQbaxNZOcwQAb2b1GK7w2ATA4apOhQqtDXdHmeVIWhWEzdBOV0nXRqQCkyNp98 >>>> cGqYxE90JnYCzRZO80wGH0qqeZvFBJ0lXASIzD+t0hXYUcC4Q+jnHMXo8ukl5/R7 >>>> hCtB7LIc7Ijh8LcQaDLYdCZGduZBGt1yE7Uqp0qmo1Mt5jBlnzSF4OvXatsD50nd >>>> z6KV1YIgWwXTyMn0SbOkwpYBXBT4kA== >>>> =kiPB >>>> -----END PGP SIGNATURE----- >>
