Re: ArrayCollection Mustella test failing

[Justin Mclean]

Hi,

> Hmm.  I pulled all the latest code.  Are you synced up as well?
All synced.

> Just to make sure I understand your situation:  This test app does report
> '3' on the latest code for you, but the mustella test keeps reporting '4'?
Correct.

>  Or set breakpoint on
> ListCollectionView:listChangeHandler and see if it goes into
> moveItemsIntoView,
Yes it does via the dispatch of the property change event which removes the 
item (leaving 3 items).

moveItemsIntoView is called if sort is effected or there a filter function:
             updateEntry.move =
                    updateEntry.move
                    || filterFunction
                    || !updateInfo.property
                    || (sort && 
sort.propertyAffectsSort(String(updateInfo.property)));

> properly removes the item, but in addItemsToView it goes down the sort path 
> so the filter test is never run?
Yes looks like the filter test is never run but the item is always removed if 
there is a filter (in 4.10).

I think the code should be this:

             updateEntry.move =
                    updateEntry.move
                    || filterFunction && filterFunction(item)
                    || !updateInfo.property
                    || (sort && 
sort.propertyAffectsSort(String(updateInfo.property)));

Mind that still doesn't explain why the corrected mustella test is still 
failing.

Thanks,
Justin