On 5/20/13 9:39 PM, "Justin Mclean" <[email protected]> wrote:
> > >> AddItemsToView already has a filterFunction test in it >Which is never called as we're changing an object's property not adding a >new object. The event type is "update" not "add". This is a bit disturbing. From my develop branch, in your earlier sample app, addItemsToView was definitely being called. I noticed in your commit that you did add a filter test to the updateEntry.move. Was that change pending when you were running your tests? That would explain why we are getting different results. > >The fix I just checked in also seems to fix the Mustella test but still a >little confused to why that is - may just be a side effect? Again, it appears your fix may now avoid calls to addItemsToView which was potentially buggy. It occurred to me that your changes solve the problem we've been investigating, but still leave addItemsToView exposed to doing something wrong in an ADD situation. It might be better to try to get addItemsToView to "do the right thing". > >Thanks, >Justin
