Hi Maurice, All discussions about this code and any code should happen on the dev list. Direct mail should be avoided if possible. That is part of the Apache Way. This mailing list is the 'common area' where this distributed team gets together and discusses just about everything.
Rest of the answers (actually opinions) in-line. On 9/25/13 9:09 AM, "Maurice Amsellem" <maurice.amsel...@systar.com> wrote: >Thank you Alex. > >The instructions are clear. > >I will prepare the files for check-in (adding headers and notice). > >I have some more questions regarding the integration: >1) Should I also move the files to different packages (eg. >spark.components in experimental) Sure. It could be done post-checkin as well, but would probably make the repo history look cleaner. >2) should I rename the classes to comply with the rest of the source code > (eg. MobileDataGrid to DataGrid). I think I'd leave the name alone. We can change it later. If you end up with spark.components.DataGrid that will be a name collision with the existing one. >3) Should I add ASDOC comments on the public API, or at least a small >comment on each class describing its purpose? Before release, we will want the ASDoc to look as thorough as the rest of the experimental components. You can work on that now or later. And more comments certainly helps. >4) I had to monkey-patch ItemLabelRenderer to make some variables >protected, and abstract it (ie remove the default label and labelDisplay) >so that I >it becomes "empty" base class for my renderers (typically >ListMultiPartItemRenderer). >To avoid code duplication, would it be possible to make some "neutral" >changes in ItemLabelRenderer, or even split it into ItemRendererBase (no >label) and ItemLabelRenderer. Assuming we complete the process of giving you write access, the Apache Way says that you can just do it or start a discussion topic about doing it. Someone will veto it if there is a technical reason not to do it, so you have to decide whether it is so much work that it is better to discuss before doing. >5) more questions to go... And that's expected and we look forward to more contributions and discussion from you in the future. -Alex
