Understood. In this case, I' am changing the test code so that it matches the existing baseline, not changing the baseline. So it should not have any impact.
Maurice -----Message d'origine----- De : Alex Harui [mailto:[email protected]] Envoyé : jeudi 10 octobre 2013 02:43 À : [email protected]; Maurice Amsellem Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed) When you change a test please consider impact on folks who might have pixel tuned their app and may notice the difference. I'm not saying don't change, but be careful. Sent via the PANTECH Discover, an AT&T 4G LTE smartphone. Maurice Amsellem <[email protected]> wrote: No, because the test on line 579 is: var showBorder:Boolean = !isNaN(borderThickness); In the desktop skin, I am setting it that way: var showBorder:Boolean = !isNaN(borderThickness) || borderThickness > 0 ; Should I change the test ? Maurice -----Message d'origine----- De : Justin Mclean [mailto:[email protected]] Envoyé : jeudi 10 octobre 2013 01:23 À : [email protected] Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed) Hi, > So the variable showBorder on line 579 is set to true. If borderThinkness is 0 shouldn't showBorder be false? Then the callout should be in the right position. Thanks, Justin
