After running the test again, I realize there is a bug in the existing code:
In \flex-sdk\mustella\tests\mobile\SplitViewNavigator\integration\baselines\Callout_skin@android_240ppi.png The thick red border surrounds the frame, but not the arrow. https://dl.dropboxusercontent.com/u/12169005/ApacheFlex/Callout_skin%40android_240ppi_current.png This is fixed in the new code: https://dl.dropboxusercontent.com/u/12169005/ApacheFlex/Callout_skin%40android_240ppi_fixed.png So I will actually need to change these baseline bitmaps (for the good): Callout_skin@android_240ppi.png Callout_skin@iphone_320ppi.png Callout_skin@qnx_160ppi.png Callout_skin@win_160ppi.png Callout_skin@win_320ppi.png I know how to generate the first one: run the test so that it generates " Callout_skin@android_240ppi.png.bad.png" and rename it to Callout_skin@android_240ppi.png But how do I generate the 4 other ones? I tried different Target_os_name and adl_extras but it didn't work. Please can you advise. Maurice -----Message d'origine----- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : jeudi 10 octobre 2013 08:52 À : Alex Harui; dev@flex.apache.org Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed) Understood. In this case, I' am changing the test code so that it matches the existing baseline, not changing the baseline. So it should not have any impact. Maurice -----Message d'origine----- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 10 octobre 2013 02:43 À : dev@flex.apache.org; Maurice Amsellem Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed) When you change a test please consider impact on folks who might have pixel tuned their app and may notice the difference. I'm not saying don't change, but be careful. Sent via the PANTECH Discover, an AT&T 4G LTE smartphone. Maurice Amsellem <maurice.amsel...@systar.com> wrote: No, because the test on line 579 is: var showBorder:Boolean = !isNaN(borderThickness); In the desktop skin, I am setting it that way: var showBorder:Boolean = !isNaN(borderThickness) || borderThickness > 0 ; Should I change the test ? Maurice -----Message d'origine----- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : jeudi 10 octobre 2013 01:23 À : dev@flex.apache.org Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed) Hi, > So the variable showBorder on line 579 is set to true. If borderThinkness is 0 shouldn't showBorder be false? Then the callout should be in the right position. Thanks, Justin
