Ok so I had a look at the JS Code generated. In StorageExample it seems to be looking for the cordova dependency as WebStorageProvider.js seems to require it. So I compared the generated code of the Maven build with that of the Ant build and I could see that not all of the "goog.require" statements are included in the Ant build. So the problem seems to be the Storage library and not the StorageExample. That's at least another step further. So now I'll investigate why the Maven build adds these "goog.require" statements and the Ant one doesn't.
Chris ________________________________ Von: Christofer Dutz <christofer.d...@c-ware.de> Gesendet: Sonntag, 3. Juli 2016 11:23:07 An: Alex Harui; dev@flex.apache.org Betreff: AW: AW: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the maven migration Hi Alex, I tried adding the js-output-optimization option to the build, but as soon as I add that to the config file, the compiler complains about the element containing invalid CDATA which I debugged and it throws that exception as soon as it contains any content at all. But I tried providing that option by adding it to the command line and it didn't really change anything. Chris ________________________________ Von: Alex Harui <aha...@adobe.com> Gesendet: Sonntag, 3. Juli 2016 08:40:18 An: dev@flex.apache.org; Christofer Dutz Betreff: Re: AW: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the maven migration OK, took a look. CreateJSExample and FlexJSStore_jquery also have the compiler option: -js-output-optimization=skipFunctionCoercions for the JS build. StorageExample still doesn't have cordova.swc from the externs in the pom and config.xml. HTH, -Alex On 7/2/16, 7:59 AM, "Alex Harui" <aha...@adobe.com> wrote: >I will look tonight. I have family stuff today. > >-Alex > >From: Christofer Dutz ><christofer.d...@c-ware.de<mailto:christofer.d...@c-ware.de>> >Date: Saturday, July 2, 2016 at 7:49 AM >To: Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>>, >"dev@flex.apache.org<mailto:dev@flex.apache.org>" ><dev@flex.apache.org<mailto:dev@flex.apache.org>> >Subject: AW: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing >the maven migration > > >Hi Alex, > > >I added the extern to the external library path. Currently I am using the >maven scope "provided" for playerglobal and airglobal as it should be, to >add a library to the external lib path and am mis-using the "runtime" >scope a little for the rest. I just pushed my changes. So if you set no >scope, the default "compile" scope will add a library to the lib-path and >if you set the scope to "provided" or "runtime" it will be added to the >external-lib-path. > > >You can always have a look at exactly what is used to compile by having a >look at the generated config xmls in the target directory. They are >generated from the config options of the pom on every build. > > >So if you run a build and have a look, do you see anything fishy? > > >Chris > > > >________________________________ >Von: Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> >Gesendet: Samstag, 2. Juli 2016 16:36:39 >An: Christofer Dutz; dev@flex.apache.org<mailto:dev@flex.apache.org> >Betreff: Re: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing >the maven migration > >When it gets added to the build, does it get added to library-path or >external-library-path? For these "extern" swcs, we want them added to >the external-library-path. Ideally, there would be a way to control that >from the POM. > >SWCs in the library-path are supposed to contain .JS files for inclusion >in the output. The compiler looks for js/out and js/src in the SWC. > >SWCs in the external-library-path are supposed to contain externs/ folder >that contains .JS files in "externs" format for use by Google Closure >Compiler to resolve APIs without looking for JS files containing real >code. > >In my Maven results, the .js files look like they are in the right place. > >The Ant builds don't currently build examples for time and size reasons. > >HTH, >-Alex > >From: Christofer Dutz ><christofer.d...@c-ware.de<mailto:christofer.d...@c-ware.de>> >Date: Saturday, July 2, 2016 at 7:20 AM >To: Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>>, >"dev@flex.apache.org<mailto:dev@flex.apache.org>" ><dev@flex.apache.org<mailto:dev@flex.apache.org>> >Subject: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the >maven migration > > >Ok, so I implemented this functionality. If a extern dependency is >directly added to a pom, it is added to the build. > > >Unfortunately it still seems to fail. > >So I debugged the compiler especially the GoogDepsWriter which is >reporting the error. > >It is trying to find all sorts of "createjs/DisplayObject.js" files in >different directories like "js/out", "js/src". I found these in the >normal SWCs like Core.swc. If I look at the extern SWCs, the content >seems different. If I have a look at the maven and the ant extern-swcs >they seem to contain all classes without package in a "externs" directory >and I can see the DisplayObject.js file in the >"target/javascript/bin/js-debug/extern" directory. > > >I would have liked to compare my examples with the official ones, just to >find out how the working directory of the Ant build looks like, but there >doesn't seem to be a Jenkins job for these. I think there should be one. > > >Looking at the code of the GoogDepsWriter I can't see any code that would >have found the DisplayObject.js file, even when using the ant externs. > > >Chris > >________________________________ >Von: Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> >Gesendet: Freitag, 1. Juli 2016 20:32:20 >An: Christofer Dutz; dev@flex.apache.org<mailto:dev@flex.apache.org> >Betreff: Re: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the >maven migration > >Makes sense. IMO, the general principle is that someone building an app >may need to include a single externs swc, even one that we didn't build >ourselves. When building applications, in theory you should be able to >specify third-party SWCs that go in the external-library-path and >library-path. I assume you'll find a way to make that happen. > >Thanks, >-Alex > >From: Christofer Dutz ><christofer.d...@c-ware.de<mailto:christofer.d...@c-ware.de>> >Date: Friday, July 1, 2016 at 11:19 AM >To: Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>>, >"dev@flex.apache.org<mailto:dev@flex.apache.org>" ><dev@flex.apache.org<mailto:dev@flex.apache.org>> >Subject: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the >maven migration > > >I have a lot of changes locally that I haven't comited yet. > >I usually filtered the non-extern and extern libraries so in some parts I >need only the externs and in others I don't want the externs. Now in >order to allow adding externs to the examples I turned off the filter. >Now things started working where the externs were needed, but it seems to >have broken other things :-( I guess the reason for my problems now are >that now not only the swcs are included, but also all the externs they >reference and I think I have to come up with a way to filter out externs, >but let through ones explicitly added ... I'm digging into this at the >moment. > > >Chris > >________________________________ >Von: Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> >Gesendet: Freitag, 1. Juli 2016 20:12:48 >An: dev@flex.apache.org<mailto:dev@flex.apache.org>; Christofer Dutz >Betreff: Re: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the >maven migration > >FWIW, I just pulled and rebuilt and am not getting the "percentage not >allowed here" problem, just the issue with the missing swcs. > >-Alex > >On 7/1/16, 8:25 AM, "Alex Harui" ><aha...@adobe.com<mailto:aha...@adobe.com>> wrote: > >>Percentage is controlled by metadata in the core swc. >> >>Sent from my LG G3, an AT&T 4G LTE smartphone >> >>------ Original message------ >>From: Christofer Dutz >>Date: Fri, Jul 1, 2016 4:56 AM >>To: dev@flex.apache.org<mailto:dev@flex.apache.org>; >>Subject:AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the maven >>migration >> >>Ok ... so I found another problem and fixed that which resulted in 5 >>projects breaking again but this time the problems I seem to be having >>look valid. >> >> >>One that's troubling me most at the moment is the one in FlexJSStore, >>FlexJSStore_jquery, MobileMap, MobileTrader and StorageExample in which I >>am getting compiler errors that I am not allowed to put percentage values >>in width and height settings. >> >> >>/Users/christoferdutz/Projects/Apache/Flex/flex-asjs/examples/flexjs/Flex >>J >>SStore_jquery/src/FlexJSStore.mxml:228 >>Initializer for 'width': percentage not allowed here: '100%'. >> <js:ControlBar id="acb" width="100%" >>className="storeControlBar" > >> >>Don't quite know what's going wrong here. >> >>Any Ideas? >> >>Chris >>________________________________ >>Von: Christofer Dutz >><christofer.d...@c-ware.de<mailto:christofer.d...@c-ware.de>> >>Gesendet: Freitag, 1. Juli 2016 11:09:04 >>An: dev@flex.apache.org<mailto:dev@flex.apache.org> >>Betreff: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the maven >>migration >> >>Hi Alex, >> >> >>That worked ... thanks ... 3 to go [?] >> >> >>Chris >> >>________________________________ >>Von: Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> >>Gesendet: Donnerstag, 30. Juni 2016 23:56:10 >>An: dev@flex.apache.org<mailto:dev@flex.apache.org> >>Betreff: Re: AW: AW: AW: [Falcon][FlexJS] Help with finishing the maven >>migration >> >> >> >>On 6/30/16, 11:07 AM, "Alex Harui" >><aha...@adobe.com<mailto:aha...@adobe.com>> wrote: >>> >>>> >>>>DataBindingExample_as >>>> >>>>File not found: org.apache.flex.html.beads.CSSButtonView >>> >>>I will look into this. >> >>Turns out there is a CONFIG::as_only conditional compilation flag that >>needs to be false for the JS build. I don't know how to make that >>change. >> >>Thanks, >>-Alex >> >
