Hi all, I just find an issue when testing connector DDLs against blink planner for rc2. This issue lead to the DDL doesn't work when containing timestamp/date/time type. I have created an issue FLINK-13699[1] and a pull request for this.
IMO, this can be a blocker issue of 1.9 release. Because timestamp/date/time are primitive types, and this will break the DDL feature. However, I want to hear more thoughts from the community whether we should recognize it as a blocker. Thanks, Jark [1]: https://issues.apache.org/jira/browse/FLINK-13699 On Mon, 12 Aug 2019 at 22:46, Becket Qin <becket....@gmail.com> wrote: > Thanks Gordon, will do that. > > On Mon, Aug 12, 2019 at 4:42 PM Tzu-Li (Gordon) Tai <tzuli...@apache.org> > wrote: > > > Concerning FLINK-13231: > > > > Since this is a @PublicEvolving interface, technically it is ok to break > > it across releases (including across bugfix releases?). > > So, @Becket if you do merge it now, please mark the fix version as 1.9.1. > > > > During the voting process, in the case a new RC is created, we usually > > check the list of changes compared to the previous RC, and correct the > "Fix > > Version" of the corresponding JIRAs to be the right version (in the case, > > it would be corrected to 1.9.0 instead of 1.9.1). > > > > On Mon, Aug 12, 2019 at 4:25 PM Till Rohrmann <trohrm...@apache.org> > > wrote: > > > >> I agree that it would be nicer. Not sure whether we should cancel the RC > >> for this issue given that it is open for quite some time and hasn't been > >> addressed until very recently. Maybe we could include it on the > shortlist > >> of nice-to-do things which we do in case that the RC gets cancelled. > >> > >> Cheers, > >> Till > >> > >> On Mon, Aug 12, 2019 at 4:18 PM Becket Qin <becket....@gmail.com> > wrote: > >> > >>> Hi Till, > >>> > >>> Yes, I think we have already documented in that way. So technically > >>> speaking it is fine to change it later. It is just better if we could > >>> avoid > >>> doing that. > >>> > >>> Thanks, > >>> > >>> Jiangjie (Becket) Qin > >>> > >>> On Mon, Aug 12, 2019 at 4:09 PM Till Rohrmann <trohrm...@apache.org> > >>> wrote: > >>> > >>> > Could we say that the PubSub connector is public evolving instead? > >>> > > >>> > Cheers, > >>> > Till > >>> > > >>> > On Mon, Aug 12, 2019 at 3:18 PM Becket Qin <becket....@gmail.com> > >>> wrote: > >>> > > >>> > > Hi all, > >>> > > > >>> > > FLINK-13231(palindrome!) has a minor Google PubSub connector API > >>> change > >>> > > regarding how to config rate limiting. The GCP PubSub connector is > a > >>> > newly > >>> > > introduced connector in 1.9, so it would be nice to include this > >>> change > >>> > > into 1.9 rather than later to avoid a public API change. I am > >>> thinking of > >>> > > making this as a blocker for 1.9. Want to check what do others > think. > >>> > > > >>> > > Thanks, > >>> > > > >>> > > Jiangjie (Becket) Qin > >>> > > > >>> > > On Mon, Aug 12, 2019 at 2:04 PM Zili Chen <wander4...@gmail.com> > >>> wrote: > >>> > > > >>> > > > Hi Kurt, > >>> > > > > >>> > > > Thanks for your explanation. For [1] I think at least we should > >>> change > >>> > > > the JIRA issue field, like unset the fixed version. For [2] I can > >>> see > >>> > > > the change is all in test scope but wonder if such a commit still > >>> > invalid > >>> > > > the release candidate. IIRC previous RC VOTE threads would > contain > >>> a > >>> > > > release manual/guide, I will try to look up it, too. > >>> > > > > >>> > > > Best, > >>> > > > tison. > >>> > > > > >>> > > > > >>> > > > Kurt Young <ykt...@gmail.com> 于2019年8月12日周一 下午5:42写道： > >>> > > > > >>> > > > > Hi Zili, > >>> > > > > > >>> > > > > Thanks for the heads up. The 2 issues you mentioned were opened > >>> by > >>> > me. > >>> > > We > >>> > > > > have > >>> > > > > found the reason of the second issue and a PR was opened for > it. > >>> As > >>> > > said > >>> > > > in > >>> > > > > jira, the > >>> > > > > issue was just a testing problem, should not be blocker of > 1.9.0 > >>> > > release. > >>> > > > > However, > >>> > > > > we will still merge it into 1.9 branch. > >>> > > > > > >>> > > > > Best, > >>> > > > > Kurt > >>> > > > > > >>> > > > > > >>> > > > > On Mon, Aug 12, 2019 at 5:38 PM Zili Chen < > wander4...@gmail.com> > >>> > > wrote: > >>> > > > > > >>> > > > > > Hi, > >>> > > > > > > >>> > > > > > I just noticed that a few hours ago there were two new issues > >>> > > > > > filed and marked as blockers to 1.9.0[1][2]. > >>> > > > > > > >>> > > > > > Now [1] is closed as duplication but still marked as > >>> > > > > > a blocker to 1.9.0, while [2] is downgrade to "Major" > priority > >>> > > > > > but still target to be fixed in 1.9.0. > >>> > > > > > > >>> > > > > > It would be worth to have attention of our release manager at > >>> > least. > >>> > > > > > > >>> > > > > > Best, > >>> > > > > > tison. > >>> > > > > > > >>> > > > > > [1] https://issues.apache.org/jira/browse/FLINK-13687 > >>> > > > > > [2] https://issues.apache.org/jira/browse/FLINK-13688 > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > Gyula Fóra <gyula.f...@gmail.com> 于2019年8月12日周一 下午5:10写道： > >>> > > > > > > >>> > > > > > > Thanks Stephan :) > >>> > > > > > > That looks easy enough, will try! > >>> > > > > > > > >>> > > > > > > Gyula > >>> > > > > > > > >>> > > > > > > On Mon, Aug 12, 2019 at 11:00 AM Stephan Ewen < > >>> se...@apache.org> > >>> > > > > wrote: > >>> > > > > > > > >>> > > > > > > > Hi Gyula! > >>> > > > > > > > > >>> > > > > > > > Thanks for reporting this. > >>> > > > > > > > > >>> > > > > > > > Can you try to simply build Flink without Hadoop and then > >>> > > exporting > >>> > > > > > > > HADOOP_CLASSPATH to your CloudEra libs? > >>> > > > > > > > That is the recommended way these days. > >>> > > > > > > > > >>> > > > > > > > Best, > >>> > > > > > > > Stephan > >>> > > > > > > > > >>> > > > > > > > > >>> > > > > > > > > >>> > > > > > > > On Mon, Aug 12, 2019 at 10:48 AM Gyula Fóra < > >>> > > gyula.f...@gmail.com> > >>> > > > > > > wrote: > >>> > > > > > > > > >>> > > > > > > > > Thanks Dawid, > >>> > > > > > > > > > >>> > > > > > > > > In the meantime I also figured out that I need to build > >>> the > >>> > > > > > > > > https://github.com/apache/flink-shaded project locally > >>> with > >>> > > > > > > > > -Dhadoop.version set to the specific hadoop version if > I > >>> want > >>> > > > > > something > >>> > > > > > > > > different. > >>> > > > > > > > > > >>> > > > > > > > > Cheers, > >>> > > > > > > > > Gyula > >>> > > > > > > > > > >>> > > > > > > > > On Mon, Aug 12, 2019 at 9:54 AM Dawid Wysakowicz < > >>> > > > > > > dwysakow...@apache.org > >>> > > > > > > > > > >>> > > > > > > > > wrote: > >>> > > > > > > > > > >>> > > > > > > > > > Hi Gyula, > >>> > > > > > > > > > > >>> > > > > > > > > > As for the issues with mapr maven repository, you > might > >>> > have > >>> > > a > >>> > > > > look > >>> > > > > > > at > >>> > > > > > > > > > this message: > >>> > > > > > > > > > > >>> > > > > > > > > > > >>> > > > > > > > > > >>> > > > > > > > > >>> > > > > > > > >>> > > > > > > >>> > > > > > >>> > > > > >>> > > > >>> > > >>> > https://lists.apache.org/thread.html/77f4db930216e6da0d6121065149cef43ff3ea33c9ffe9b1a3047210@%3Cdev.flink.apache.org%3E > >>> > > > > > > > > > > >>> > > > > > > > > > Try using the "unsafe-mapr-repo" profile. > >>> > > > > > > > > > > >>> > > > > > > > > > Best, > >>> > > > > > > > > > > >>> > > > > > > > > > Dawid > >>> > > > > > > > > > > >>> > > > > > > > > > On 11/08/2019 19:31, Gyula Fóra wrote: > >>> > > > > > > > > > > Hi again, > >>> > > > > > > > > > > > >>> > > > > > > > > > > How do I build the RC locally with the hadoop > version > >>> > > > > specified? > >>> > > > > > > > Seems > >>> > > > > > > > > > like > >>> > > > > > > > > > > no matter what I do I run into dependency problems > >>> with > >>> > the > >>> > > > > > shaded > >>> > > > > > > > > hadoop > >>> > > > > > > > > > > dependencies. > >>> > > > > > > > > > > This seems to have worked in the past. > >>> > > > > > > > > > > > >>> > > > > > > > > > > There might be some documentation somewhere that I > >>> > couldnt > >>> > > > > find, > >>> > > > > > > so I > >>> > > > > > > > > > would > >>> > > > > > > > > > > appreciate any pointers :) > >>> > > > > > > > > > > > >>> > > > > > > > > > > Thanks! > >>> > > > > > > > > > > Gyula > >>> > > > > > > > > > > > >>> > > > > > > > > > > On Sun, Aug 11, 2019 at 6:57 PM Gyula Fóra < > >>> > > > > gyula.f...@gmail.com > >>> > > > > > > > >>> > > > > > > > > wrote: > >>> > > > > > > > > > > > >>> > > > > > > > > > >> Hi! > >>> > > > > > > > > > >> > >>> > > > > > > > > > >> I am trying to build 1.9.0-rc2 with the > >>> -Pvendor-repos > >>> > > > profile > >>> > > > > > > > > enabled. > >>> > > > > > > > > > I > >>> > > > > > > > > > >> get the following error: > >>> > > > > > > > > > >> > >>> > > > > > > > > > >> mvn clean install -DskipTests -Pvendor-repos > >>> > > > > > > -Dhadoop.version=2.6.0 > >>> > > > > > > > > > >> -Pinclude-hadoop (ignore that the hadoop version > is > >>> not > >>> > a > >>> > > > > vendor > >>> > > > > > > > > hadoop > >>> > > > > > > > > > >> version) > >>> > > > > > > > > > >> > >>> > > > > > > > > > >> [ERROR] Failed to execute goal on project > >>> > flink-hadoop-fs: > >>> > > > > Could > >>> > > > > > > not > >>> > > > > > > > > > >> resolve dependencies for project > >>> > > > > > > > > > >> org.apache.flink:flink-hadoop-fs:jar:1.9.0: Failed > >>> to > >>> > > > collect > >>> > > > > > > > > > dependencies > >>> > > > > > > > > > >> at > >>> org.apache.flink:flink-shaded-hadoop-2:jar:2.6.0-7.0: > >>> > > > > Failed > >>> > > > > > to > >>> > > > > > > > > read > >>> > > > > > > > > > >> artifact descriptor for > >>> > > > > > > > > > >> > >>> org.apache.flink:flink-shaded-hadoop-2:jar:2.6.0-7.0: > >>> > > Could > >>> > > > > not > >>> > > > > > > > > transfer > >>> > > > > > > > > > >> artifact > >>> > > > org.apache.flink:flink-shaded-hadoop-2:pom:2.6.0-7.0 > >>> > > > > > > > from/to > >>> > > > > > > > > > >> mapr-releases (https://repository.mapr.com/maven/ > ): > >>> > > > > > > > > > >> sun.security.validator.ValidatorException: PKIX > path > >>> > > > building > >>> > > > > > > > failed: > >>> > > > > > > > > > >> > >>> > > sun.security.provider.certpath.SunCertPathBuilderException: > >>> > > > > > unable > >>> > > > > > > > to > >>> > > > > > > > > > find > >>> > > > > > > > > > >> valid certification path to requested target -> > >>> [Help 1] > >>> > > > > > > > > > >> > >>> > > > > > > > > > >> This looks like a TLS error. Might not be related > >>> to the > >>> > > > > release > >>> > > > > > > but > >>> > > > > > > > > it > >>> > > > > > > > > > >> could be good to know. > >>> > > > > > > > > > >> > >>> > > > > > > > > > >> Cheers, > >>> > > > > > > > > > >> Gyula > >>> > > > > > > > > > >> > >>> > > > > > > > > > >> On Fri, Aug 9, 2019 at 6:26 PM Tzu-Li (Gordon) > Tai < > >>> > > > > > > > > tzuli...@apache.org > >>> > > > > > > > > > > > >>> > > > > > > > > > >> wrote: > >>> > > > > > > > > > >> > >>> > > > > > > > > > >>> Please note that the unresolved issues that are > >>> still > >>> > > > tagged > >>> > > > > > > with a > >>> > > > > > > > > fix > >>> > > > > > > > > > >>> version "1.9.0", as seen in the JIRA release > notes > >>> [1], > >>> > > are > >>> > > > > > > issues > >>> > > > > > > > to > >>> > > > > > > > > > >>> update documents for new features. > >>> > > > > > > > > > >>> I've left them still associated with 1.9.0 since > >>> these > >>> > > > should > >>> > > > > > > still > >>> > > > > > > > > be > >>> > > > > > > > > > >>> updated for 1.9.0 soon along with the official > >>> release. > >>> > > > > > > > > > >>> > >>> > > > > > > > > > >>> [1] > >>> > > > > > > > > > >>> > >>> > > > > > > > > > >>> > >>> > > > > > > > > > > >>> > > > > > > > > > >>> > > > > > > > > >>> > > > > > > > >>> > > > > > > >>> > > > > > >>> > > > > >>> > > > >>> > > >>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12344601 > >>> > > > > > > > > > >>> > >>> > > > > > > > > > >>> On Fri, Aug 9, 2019 at 6:17 PM Tzu-Li (Gordon) > Tai > >>> < > >>> > > > > > > > > > tzuli...@apache.org> > >>> > > > > > > > > > >>> wrote: > >>> > > > > > > > > > >>> > >>> > > > > > > > > > >>>> Hi all, > >>> > > > > > > > > > >>>> > >>> > > > > > > > > > >>>> Release candidate #2 for Apache Flink 1.9.0 is > now > >>> > ready > >>> > > > for > >>> > > > > > > your > >>> > > > > > > > > > >>> review. > >>> > > > > > > > > > >>>> This is the first voting candidate for 1.9.0, > >>> > following > >>> > > > the > >>> > > > > > > > preview > >>> > > > > > > > > > >>>> candidates RC0 and RC1. > >>> > > > > > > > > > >>>> > >>> > > > > > > > > > >>>> Please review and vote on release candidate #2 > for > >>> > > version > >>> > > > > > > 1.9.0, > >>> > > > > > > > as > >>> > > > > > > > > > >>>> follows: > >>> > > > > > > > > > >>>> [ ] +1, Approve the release > >>> > > > > > > > > > >>>> [ ] -1, Do not approve the release (please > provide > >>> > > > specific > >>> > > > > > > > > comments) > >>> > > > > > > > > > >>>> > >>> > > > > > > > > > >>>> The complete staging area is available for your > >>> > review, > >>> > > > > which > >>> > > > > > > > > > includes: > >>> > > > > > > > > > >>>> * JIRA release notes [1], > >>> > > > > > > > > > >>>> * the official Apache source release and binary > >>> > > > convenience > >>> > > > > > > > releases > >>> > > > > > > > > > to > >>> > > > > > > > > > >>> be > >>> > > > > > > > > > >>>> deployed to dist.apache.org [2], which are > signed > >>> > with > >>> > > > the > >>> > > > > > key > >>> > > > > > > > with > >>> > > > > > > > > > >>>> fingerprint > >>> 1C1E2394D3194E1944613488F320986D35C33D6A > >>> > > [3], > >>> > > > > > > > > > >>>> * all artifacts to be deployed to the Maven > >>> Central > >>> > > > > Repository > >>> > > > > > > > [4], > >>> > > > > > > > > > >>>> * source code tag “release-1.9.0-rc2” [5]. > >>> > > > > > > > > > >>>> > >>> > > > > > > > > > >>>> Robert is also preparing a pull request for the > >>> > > > announcement > >>> > > > > > > blog > >>> > > > > > > > > post > >>> > > > > > > > > > >>> in > >>> > > > > > > > > > >>>> the works, and will update this voting thread > >>> with a > >>> > > link > >>> > > > to > >>> > > > > > the > >>> > > > > > > > > pull > >>> > > > > > > > > > >>>> request shortly afterwards. > >>> > > > > > > > > > >>>> > >>> > > > > > > > > > >>>> The vote will be open for *at least 72 hours*. > >>> > > > > > > > > > >>>> Please cast your votes before *Aug. 14th (Wed.) > >>> 2019, > >>> > > > 17:00 > >>> > > > > PM > >>> > > > > > > > > CET*.It > >>> > > > > > > > > > >>> is > >>> > > > > > > > > > >>>> adopted by majority approval, with at least 3 > PMC > >>> > > > > affirmative > >>> > > > > > > > votes. > >>> > > > > > > > > > >>>> Thanks, > >>> > > > > > > > > > >>>> Gordon[1] > >>> > > > > > > > > > >>>> > >>> > > > > > > > > > >>> > >>> > > > > > > > > > > >>> > > > > > > > > > >>> > > > > > > > > >>> > > > > > > > >>> > > > > > > >>> > > > > > >>> > > > > >>> > > > >>> > > >>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12344601 > >>> > > > > > > > > > >>>> [2] > >>> > > > > > > > >>> https://dist.apache.org/repos/dist/dev/flink/flink-1.9.0-rc2/ > >>> > > > > > > > > > >>>> [3] > >>> > > https://dist.apache.org/repos/dist/release/flink/KEYS > >>> > > > > > > > > > >>>> [4] > >>> > > > > > > > > > >>> > >>> > > > > > > > > > >>> > > > > > > >>> > > > >>> https://repository.apache.org/content/repositories/orgapacheflink-1234 > >>> > > > > > > > > > >>>> [5] > >>> > > > > > > > > > >>>> > >>> > > > > > > > > > >>> > >>> > > > > > > > > > > >>> > > > > > > > > > >>> > > > > > > > > >>> > > > > > > > >>> > > > > > > >>> > > > > > >>> > > > > >>> > > > >>> > > >>> > https://gitbox.apache.org/repos/asf?p=flink.git;a=tag;h=refs/tags/release-1.9.0-rc2 > >>> > > > > > > > > > > >>> > > > > > > > > > > >>> > > > > > > > > > >>> > > > > > > > > >>> > > > > > > > >>> > > > > > > >>> > > > > > >>> > > > > >>> > > > >>> > > >>> > >> >
