Thanks Chesnay for the nice work, it's very helpful Best, Congxian
Terry Wang <zjuwa...@gmail.com> 于2019年8月26日周一 下午6:59写道： > Very helpful! Thanks Chesnay! > Best, > Terry Wang > > > > > 在 2019年8月23日，下午11:47，Ethan Li <ethanopensou...@gmail.com> 写道： > > > > Thank you very much Chesnay! This is helpful > > > >> On Aug 23, 2019, at 2:58 AM, Chesnay Schepler <ches...@apache.org> > wrote: > >> > >> @Ethan Li The source for the CiBot is available here < > https://github.com/flink-ci/ci-bot/>. The implementation of this command > is tightly connected to how the CiBot works; but conceptually it looks at a > PR, finds the most recent build that ran, and uses the Travis REST API to > restart the build. > >> Additionally, it keeps track of which comments have been processed by > storing the comment ID in the CI report. > >> If you have further questions, feel free to ping me directly. > >> > >> @Dianfu I agree, we should include it somewhere in either the flinkbot > template or the CI report. > >> > >> On 23/08/2019 03:35, Dian Fu wrote: > >>> Thanks Chesnay for your great work! A very useful feature! > >>> > >>> Just one minor suggestion: It will be better if we could add this > command to the section "Bot commands" in the flinkbot template. > >>> > >>> Regards, > >>> Dian > >>> > >>>> 在 2019年8月23日，上午2:06，Ethan Li <ethanopensou...@gmail.com> 写道： > >>>> > >>>> My question is specifically about implementation of "@flinkbot run > travis" > >>>> > >>>>> On Aug 22, 2019, at 1:06 PM, Ethan Li <ethanopensou...@gmail.com> > wrote: > >>>>> > >>>>> Hi Chesnay, > >>>>> > >>>>> This is really nice feature! > >>>>> > >>>>> Can I ask how is this implemented? Do you have the related > Jira/PR/docs that I can take a look? I’d like to introduce it to another > project if applicable. Thank you very much! > >>>>> > >>>>> Best, > >>>>> Ethan > >>>>> > >>>>>> On Aug 22, 2019, at 8:34 AM, Biao Liu <mmyy1...@gmail.com <mailto: > mmyy1...@gmail.com>> wrote: > >>>>>> > >>>>>> Thanks Chesnay a lot, > >>>>>> > >>>>>> I love this feature! > >>>>>> > >>>>>> Thanks, > >>>>>> Biao /'bɪ.aʊ/ > >>>>>> > >>>>>> > >>>>>> > >>>>>> On Thu, 22 Aug 2019 at 20:55, Hequn Cheng <chenghe...@gmail.com > <mailto:chenghe...@gmail.com>> wrote: > >>>>>> > >>>>>>> Cool, thanks Chesnay a lot for the improvement! > >>>>>>> > >>>>>>> Best, Hequn > >>>>>>> > >>>>>>> On Thu, Aug 22, 2019 at 5:02 PM Zhu Zhu <reed...@gmail.com > <mailto:reed...@gmail.com>> wrote: > >>>>>>> > >>>>>>>> Thanks Chesnay for the CI improvement! > >>>>>>>> It is very helpful. > >>>>>>>> > >>>>>>>> Thanks, > >>>>>>>> Zhu Zhu > >>>>>>>> > >>>>>>>> zhijiang <wangzhijiang...@aliyun.com.invalid <mailto: > wangzhijiang...@aliyun.com.invalid>> 于2019年8月22日周四 下午4:18写道： > >>>>>>>> > >>>>>>>>> It is really very convenient now. Valuable work, Chesnay! > >>>>>>>>> > >>>>>>>>> Best, > >>>>>>>>> Zhijiang > >>>>>>>>> > ------------------------------------------------------------------ > >>>>>>>>> From:Till Rohrmann <trohrm...@apache.org <mailto: > trohrm...@apache.org>> > >>>>>>>>> Send Time:2019年8月22日(星期四) 10:13 > >>>>>>>>> To:dev <dev@flink.apache.org <mailto:dev@flink.apache.org>> > >>>>>>>>> Subject:Re: CiBot Update > >>>>>>>>> > >>>>>>>>> Thanks for the continuous work on the CiBot Chesnay! > >>>>>>>>> > >>>>>>>>> Cheers, > >>>>>>>>> Till > >>>>>>>>> > >>>>>>>>> On Thu, Aug 22, 2019 at 9:47 AM Jark Wu <imj...@gmail.com > <mailto:imj...@gmail.com>> wrote: > >>>>>>>>> > >>>>>>>>>> Great work! Thanks Chesnay! > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> On Thu, 22 Aug 2019 at 15:42, Xintong Song < > tonysong...@gmail.com <mailto:tonysong...@gmail.com>> > >>>>>>>>> wrote: > >>>>>>>>>>> The re-triggering travis feature is so convenient. Thanks > Chesnay~! > >>>>>>>>>>> > >>>>>>>>>>> Thank you~ > >>>>>>>>>>> > >>>>>>>>>>> Xintong Song > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> On Thu, Aug 22, 2019 at 9:26 AM Stephan Ewen <se...@apache.org > <mailto:se...@apache.org>> > >>>>>>>> wrote: > >>>>>>>>>>>> Nice, thanks! > >>>>>>>>>>>> > >>>>>>>>>>>> On Thu, Aug 22, 2019 at 3:59 AM Zili Chen < > wander4...@gmail.com <mailto:wander4...@gmail.com>> > >>>>>>>>>> wrote: > >>>>>>>>>>>>> Thanks for your announcement. Nice work! > >>>>>>>>>>>>> > >>>>>>>>>>>>> Best, > >>>>>>>>>>>>> tison. > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> vino yang <yanghua1...@gmail.com <mailto: > yanghua1...@gmail.com>> 于2019年8月22日周四 上午8:14写道： > >>>>>>>>>>>>> > >>>>>>>>>>>>>> +1 for "@flinkbot run travis", it is very convenient. > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> Chesnay Schepler <ches...@apache.org <mailto: > ches...@apache.org>> 于2019年8月21日周三 > >>>>>>> 下午9:12写道： > >>>>>>>>>>>>>>> Hi everyone, > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> this is an update on recent changes to the CI bot. > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> The bot now cancels builds if a new commit was added to a > >>>>>>> PR, > >>>>>>>>> and > >>>>>>>>>>>>>>> cancels all builds if the PR was closed. > >>>>>>>>>>>>>>> (This was implemented a while ago; I'm just mentioning it > >>>>>>>> again > >>>>>>>>>> for > >>>>>>>>>>>>>>> discoverability) > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Additionally, starting today you can now re-trigger a > >>>>>>> Travis > >>>>>>>>> run > >>>>>>>>>> by > >>>>>>>>>>>>>>> writing a comment "@flinkbot run travis"; this means you no > >>>>>>>>>> longer > >>>>>>>>>>>> have > >>>>>>>>>>>>>>> to commit an empty commit or do other shenanigans to get > >>>>>>>>> another > >>>>>>>>>>>> build > >>>>>>>>>>>>>>> running. > >>>>>>>>>>>>>>> Note that this will /not/ work if the PR was re-opened, > >>>>>>> until > >>>>>>>>> at > >>>>>>>>>>>> least > >>>>>>>>>>>>> 1 > >>>>>>>>>>>>>>> new build was triggered by a push. > >>>>>>>>>>>>>>> > >>>>>>>>> > >>> > >> > > > >
