Thanks Forward ~ +1 from my side and would review your Calcite PR this weekend :) Overall it looks good, and I believe we can merge it soon ~
Best, Danny Chan 在 2020年1月10日 +0800 AM11:04,Jark Wu <imj...@gmail.com>,写道: > Thanks Forward for driving this, > > The design doc looks very good to me. > +1 from my side. > > Best, > Jark > > On Thu, 9 Jan 2020 at 20:12, Forward Xu <forwardxu...@gmail.com> wrote: > > > Hi all, > > > > Listened to the opinion of Timo since the last discussion and updated the > > document [1] Optimized the passing parameters of JSON table API. Added > > return type when describing each JSON function. It makes the documentation > > more clear. So I again vote of FLIP-90 [2] since that we have reached an > > agreement on the design in the discussion thread [3]. > > This vote will be open for at least 72 hours. Unless there is an objection, > > I will try to close it by January 12, 2020 08:00 UTC if we have received > > sufficient votes. > > Best, > > ForwardXu > > > > [1] > > > > https://docs.google.com/document/d/1JfaFYIFOAY8P2pFhOYNCQ9RTzwF4l85_bnTvImOLKMk/edit#heading=h.76mb88ca6yjp > > [2] > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=141724550 > > [3] > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Support-JSON-functions-in-Flink-SQL-td32674.html > >