Hi Till, Yes, we don't have the setting in flink-conf.yaml.
Generally, we carry forward the existing configuration and any change to default configuration values would impact the upgrade. Yes, since it is an incompatible change I would state it in the release notes. Thanks, Thomas BTW I found a performance regression while trying to upgrade another pipeline with this RC. It is a simple Kinesis to Kinesis job. Wasn't able to pin it down yet, symptoms include increased checkpoint alignment time. On Wed, Jul 1, 2020 at 12:04 AM Till Rohrmann <trohrm...@apache.org> wrote: > Hi Thomas, > > just to confirm: When starting the image in local mode, then you don't have > any of the JobManager memory configuration settings configured in the > effective flink-conf.yaml, right? Does this mean that you have explicitly > removed `jobmanager.heap.size: 1024m` from the default configuration? If > this is the case, then I believe it was more of an unintentional artifact > that it worked before and it has been corrected now so that one needs to > specify the memory of the JM process explicitly. Do you think it would help > to explicitly state this in the release notes? > > Cheers, > Till > > On Wed, Jul 1, 2020 at 7:01 AM Thomas Weise <t...@apache.org> wrote: > > > Thanks for preparing another RC! > > > > As mentioned in the previous RC thread, it would be super helpful if the > > release notes that are part of the documentation can be included [1]. > It's > > a significant time-saver to have read those first. > > > > I found one more non-backward compatible change that would be worth > > addressing/mentioning: > > > > It is now necessary to configure the jobmanager heap size in > > flink-conf.yaml (with either jobmanager.heap.size > > or jobmanager.memory.heap.size). Why would I not want to do that anyways? > > Well, we set it dynamically for a cluster deployment via the > > flinkk8soperator, but the container image can also be used for testing > with > > local mode (./bin/jobmanager.sh start-foreground local). That will fail > if > > the heap wasn't configured and that's how I noticed it. > > > > Thanks, > > Thomas > > > > [1] > > > > > https://ci.apache.org/projects/flink/flink-docs-release-1.11/release-notes/flink-1.11.html > > > > On Tue, Jun 30, 2020 at 3:18 AM Zhijiang <wangzhijiang...@aliyun.com > > .invalid> > > wrote: > > > > > Hi everyone, > > > > > > Please review and vote on the release candidate #4 for the version > > 1.11.0, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * JIRA release notes [1], > > > * the official Apache source release and binary convenience releases to > > be > > > deployed to dist.apache.org [2], which are signed with the key with > > > fingerprint 2DA85B93244FDFA19A6244500653C0A2CEA00D0E [3], > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > * source code tag "release-1.11.0-rc4" [5], > > > * website pull request listing the new release and adding announcement > > > blog post [6]. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Release Manager > > > > > > [1] > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346364 > > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.11.0-rc4/ > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > [4] > > > > https://repository.apache.org/content/repositories/orgapacheflink-1377/ > > > [5] https://github.com/apache/flink/releases/tag/release-1.11.0-rc4 > > > [6] https://github.com/apache/flink-web/pull/352 > > > > > > > > >
