+1 (non-binding) - check wheel package consistency with the built from the source code - test the built from the wheel package in mac os with python 3.6 - verify the performance for PyFlink UDFs including Python General UDF and Pandas UDF - test Python UDTF
Best, Xingbo Dian Fu <dian0511...@gmail.com> 于2020年7月3日周五 下午8:45写道： > +1 (non-binding) > > - built from source with scala 2.11 successfully > - checked the signature and checksum of the binary packages > - installed PyFlink on MacOS, Windows and Linux successfully > - tested the functionality of Pandas UDF and the conversion between > PyFlink Table and Pandas DataFrame > - verified that the Python dependency management functionality works well > > Regards, > Dian > > > 在 2020年7月3日，下午8:24，jincheng sun <sunjincheng...@gmail.com> 写道： > > > > +1(binding) > > > > Checks: > > - check wheel package consistency > > - test the built from the wheel package > > - checked the signature and checksum > > - pip installed the Python package > > `apache_flink-1.11.0-cp37-cp37m-macosx_10_9_x86_64.whl` successfully and > > run a simple word count example successfully > > - verify the performance for PyFlink UDFs > > - test Python UDTF support > > > > Best, > > Jincheng > > > > > > Leonard Xu <xbjt...@gmail.com> 于2020年7月3日周五 下午6:02写道： > > > >> +1 (non-binding) > >> > >> - checked/verified signatures and hashes > >> - built from source sing scala 2.11 succeeded > >> - go through all issues which "fixVersion" property is 1.11.0, there is > no > >> blocker. > >> - checked that there are no missing artifacts > >> - test SQL connector Elasticsearch7/JDBC/HBase/Kafka (new connector) > with > >> some queries in SQL Client, they works well and the result is expected > >> - started a cluster, WebUI was accessible, submitted a wordcount job and > >> ran succeeded, no suspicious log output > >> - the web PR looks good > >> > >> Best, > >> Leonard Xu > >
