+1 (non-binding) - Built from source - Verified hive connector tests for all hive versions - Played some simple cases with hive connector and everything seems fine
On Sat, Jul 18, 2020 at 12:24 AM Rui Li <lirui.fu...@gmail.com> wrote: > OK, I agree FLINK-18588 can wait for the next release. > > On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu <xbjt...@gmail.com> wrote: > >> +1 (non-binding) >> >> - checked/verified signatures and hashes >> - built from source code with scala 2.11 succeeded >> - checked that there are no missing artifacts >> - started a cluster, the Web UI was accessible, submitted a wordcount job >> and ran succeeded, no suspicious log output >> - test using SQL Client to submit job and the query result is expected >> - go through all issues which fix version property is 1.11.1, all issues >> are closed except FLINK-15794, >> and FLINK-15794 has fixed in master and 1.11.1 just wait for being >> fixed in 1.10.2. >> - the web PR looks good >> >> For FLINK-18588, I also agree with Timo to put it to 1.11.2 because >> it's a `Major` bug rather than `Blocker`. >> >> Best, >> Leonard > > > > -- > Best regards! > Rui Li > -- Best regards! Rui Li
