Thanks for starting this discussion Alex. I really like this feature because it gives better insights into what a Flink job is doing.
Quick question on the TaskExecutorGateway extension: * What is the requestId used for in the RPC call? * Would it make sense to group numSubSamples, delayBetweenSamples and maxStackTraceDepth into a ThreadSamplesRequest class? This would decrease the number of parameters and group those which are closely related together. Cheers, Till On Tue, Mar 2, 2021 at 12:45 AM Alexander Fedulov <alexan...@ververica.com> wrote: > Hi All, > > I would like to start a discussion for FLIP-165: Operator's Flame Graphs > [1] > > A Flame Graph [2] is a visualization that is very effective for providing > answers to the questions like: > - Which methods are currently consuming CPU resources? > - How CPU utilization by one method compares to the others? > - Which series of calls on the stack led to executing a particular method? > > I have already opened a PR [3] that represents the implementation approach > proposed in the FLIP. It supports both on-CPU and off-CPU [4] Flame Graphs. > > Looking forward to your feedback. > > P.S: I would like to give kudos to David Moravek for his prototyping work > [5] on this feature. Although the proposed implementation significantly > diverges from his prototype on the Flink side, the work done on connecting > the d3-flame-graph library to the right data structure retrieved from Flink > was instrumental for enabling this feature. > > [1] > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-165%3A+Operator%27s+Flame+Graphs > [2] http://www.brendangregg.com/flamegraphs.html > [3] https://github.com/apache/flink/pull/15054 > [4] http://www.brendangregg.com/FlameGraphs/offcpuflamegraphs.html > [5] > > https://issues.apache.org/jira/browse/FLINK-13550?focusedCommentId=17083026&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17083026 > > Best, > > -- > > Alexander Fedulov | Solutions Architect > > <https://www.ververica.com/> > > Follow us @VervericaData > > -- > > Join Flink Forward <https://flink-forward.org/> - The Apache Flink > Conference > > Stream Processing | Event Driven | Real Time > > -- > > Ververica GmbH | Invalidenstrasse 115, 10115 Berlin, Germany > > -- > > Ververica GmbH > Registered at Amtsgericht Charlottenburg: HRB 158244 B > Managing Directors: Yip Park Tung Jason, Jinwei (Kevin) Zhang, Karl Anton > Wehner >
