+1 (binding) - Checked the diff between 1.12.4 and 1.12.5-rc3: OK ( https://github.com/apache/flink/compare/release-1.12.4...release-1.12.5-rc3) - commons-io version has been bumped to 2.8.0 through FLINK-22747 and all NOTICE files updated correctly - guava version has been bumped to 29.0 for kinesis connector through FLINK-23009 and all NOTICE files updated correctly - Checked release notes: OK - minor: I've moved FLINK-23577 out of 1.12.5 - Checked sums and signatures: OK - Maven clean install from source: OK - Checked the jars in the staging repo: OK - Checked the website updates: Changes Required - Note: release note needs update but is not a blocker for the RC
Best Regards, Yu On Mon, 2 Aug 2021 at 12:25, JING ZHANG <beyond1...@gmail.com> wrote: > +1 (non-binding) > > 1. built from source code flink-1.12.5-bin-scala_2.11.tgz > < > https://dist.apache.org/repos/dist/dev/flink/flink-1.12.5-rc3/flink-1.12.5-bin-scala_2.11.tgz > > > succeeded > 2. Started a local Flink cluster, ran the WordCount example, WebUI looks > good, no suspicious output/log > 3. started cluster and run some e2e sql queries using SQL Client, query > result is expected. (Find a minor bug FLINK-23554 > <https://issues.apache.org/jira/browse/FLINK-23554> which would happen in > some corner cases, so it is not a blocker) > 4. Repeat Step 2 and 3 with flink-1.12.5-src.tgz > < > https://dist.apache.org/repos/dist/dev/flink/flink-1.12.5-rc3/flink-1.12.5-src.tgz > > > > Best, > JING ZHANG > > Dian Fu <dian0511...@gmail.com> 于2021年8月2日周一 上午9:59写道： > > > +1 (binding) > > > > - checked the website PR > > - verified the signatures and checksum > > - Installed the Python wheel package of Python 3.8 on MacOS and runs > some > > simple examples > > > > Regards, > > Dian > > > > > 2021年8月1日 下午3:32，Leonard Xu <xbjt...@gmail.com> 写道： > > > > > > +1 (non-binding) > > > > > > - verified signatures and hashsums > > > - checked all dependency artifacts are 1.12.5 > > > - started a cluster, ran a wordcount job, the result is expected, no > > suspicious log output > > > - started SQL Client, ran some sql queries in SQL Client, the result is > > expected, no suspicious log output > > > - reviewed the web PR > > > > > > Best, > > > Leonard > > > > > >> 在 2021年8月1日，15:24，Jark Wu <imj...@gmail.com> 写道： > > >> > > >> +1 (binding) > > >> > > >> - checked/verified signatures and hashes > > >> - started cluster, ran examples, verified web ui and log output, > nothing > > >> unexpected > > >> - started cluster and ran some e2e sql queries using sql-client, looks > > good: > > >> - read from kafka source, aggregate, write into mysql > > >> - read from kafka source with watermark defined in ddl, window > > aggregate, > > >> write into mysql > > >> - read from kafka with computed column defined in ddl, temporal join > > with > > >> a mysql table, write into kafka > > >> - reviewed the release PR > > >> > > >> Best, > > >> Jark > > >> > > >> On Sat, 31 Jul 2021 at 10:22, godfrey he <godfre...@gmail.com> wrote: > > >> > > >>> +1 (non-binding) > > >>> > > >>> - Checked checksums and signatures: OK > > >>> - Built from source: OK > > >>> - Checked the flink-web PR > > >>> - find one typo about flink version > > >>> - Submit some jobs from sql-client to local cluster, checked the > > web-ui, > > >>> cp, sp, log, etc: OK > > >>> > > >>> Best, > > >>> Godfrey > > >>> > > >>> Robert Metzger <rmetz...@apache.org> 于2021年7月30日周五 下午4:33写道： > > >>> > > >>>> Thanks a lot for providing the new staging repository. I dropped the > > 1440 > > >>>> and 1441 staging repositories, to avoid that other RC reviewers > > >>>> accidentally look into it, or that we accidentally release it. > > >>>> > > >>>> +1 (binding) > > >>>> > > >>>> Checks: > > >>>> - I didn't find any additional issues in the release announcement > > >>>> - the pgp signatures on the source archive seem fine > > >>>> - source archive compilation starts successfully (rat check passes > > etc.) > > >>>> - standalone mode, job submission and cli cancellation works. logs > > look > > >>>> fine > > >>>> - maven staging repository looks fine > > >>>> > > >>>> On Fri, Jul 30, 2021 at 7:30 AM Jingsong Li <jingsongl...@gmail.com > > > > >>>> wrote: > > >>>> > > >>>>> Hi everyone, > > >>>>> > > >>>>> Thanks Robert, I created a new one. > > >>>>> > > >>>>> all artifacts to be deployed to the Maven Central Repository [4], > > >>>>> > > >>>>> [4] > > >>>>> > > >>> > > https://repository.apache.org/content/repositories/orgapacheflink-1444/ > > >>>>> > > >>>>> Best, > > >>>>> Jingsong > > >>>>> > > >>>>> On Thu, Jul 29, 2021 at 9:50 PM Robert Metzger < > rmetz...@apache.org> > > >>>>> wrote: > > >>>>> > > >>>>>> The difference is that the 1440 staging repository contains the > > Scala > > >>>>> _2.11 > > >>>>>> files, the 1441 repo contains scala_2.12. I'm not sure if this > > works, > > >>>>>> because things like "flink-core:1.11.5" will be released twice? > > >>>>>> I would prefer to have a single staging repository containing all > > >>>>> binaries > > >>>>>> we intend to release to maven central, to avoid complications in > the > > >>>>>> release process. > > >>>>>> > > >>>>>> Since only the convenience binaries are affected by this, we don't > > >>> need > > >>>>> to > > >>>>>> cancel the release. We just need to create a new staging > repository. > > >>>>>> > > >>>>>> > > >>>>>> On Thu, Jul 29, 2021 at 3:36 PM Robert Metzger < > rmetz...@apache.org > > > > > >>>>>> wrote: > > >>>>>> > > >>>>>>> Thanks a lot for creating a release candidate! > > >>>>>>> > > >>>>>>> What is the difference between the two maven staging repos? > > >>>>>>> > > >>>>> > > >>> > > https://repository.apache.org/content/repositories/orgapacheflink-1440/ > > >>>>>>> and > > >>>>>>> > > >>>>> > > >>> > > https://repository.apache.org/content/repositories/orgapacheflink-1441/ > > >>>>>> ? > > >>>>>>> > > >>>>>>> On Thu, Jul 29, 2021 at 1:52 PM Xingbo Huang <hxbks...@gmail.com > > > > >>>>> wrote: > > >>>>>>> > > >>>>>>>> +1 (non-binding) > > >>>>>>>> > > >>>>>>>> - Verified checksums and signatures > > >>>>>>>> - Built from sources > > >>>>>>>> - Verified Python wheel package contents > > >>>>>>>> - Pip install Python wheel package in Mac > > >>>>>>>> - Run Python UDF job in Python REPL > > >>>>>>>> > > >>>>>>>> Best, > > >>>>>>>> Xingbo > > >>>>>>>> > > >>>>>>>> Zakelly Lan <zakelly....@gmail.com> 于2021年7月29日周四 下午5:57写道： > > >>>>>>>> > > >>>>>>>>> +1 (non-binding) > > >>>>>>>>> > > >>>>>>>>> * Built from source. > > >>>>>>>>> * Run wordcount datastream job on yarn > > >>>>>>>>> * Web UI and checkpoint seem good. > > >>>>>>>>> * Kill a container to make job failover, everything is good. > > >>>>>>>>> * Try run job from checkpoint, everything is good. > > >>>>>>>>> > > >>>>>>>>> On Thu, Jul 29, 2021 at 2:34 PM Yun Tang <myas...@live.com> > > >>>> wrote: > > >>>>>>>>> > > >>>>>>>>>> +1 (non-binding) > > >>>>>>>>>> > > >>>>>>>>>> Checked the signature. > > >>>>>>>>>> > > >>>>>>>>>> Reviewed the PR of flink-web. > > >>>>>>>>>> > > >>>>>>>>>> Download the pre-built tar package and launched an application > > >>>>> mode > > >>>>>>>>>> standalone job successfully. > > >>>>>>>>>> > > >>>>>>>>>> Best > > >>>>>>>>>> Yun Tang > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> ________________________________ > > >>>>>>>>>> From: Jingsong Li <jingsongl...@gmail.com> > > >>>>>>>>>> Sent: Tuesday, July 27, 2021 11:54 > > >>>>>>>>>> To: dev <dev@flink.apache.org> > > >>>>>>>>>> Subject: [VOTE] Release 1.12.5, release candidate #3 > > >>>>>>>>>> > > >>>>>>>>>> Hi everyone, > > >>>>>>>>>> > > >>>>>>>>>> Please review and vote on the release candidate #3 for the > > >>>> version > > >>>>>>>>> 1.12.5, > > >>>>>>>>>> as follows: > > >>>>>>>>>> [ ] +1, Approve the release > > >>>>>>>>>> [ ] -1, Do not approve the release (please provide specific > > >>>>>> comments) > > >>>>>>>>>> > > >>>>>>>>>> The complete staging area is available for your review, which > > >>>>>>>> includes: > > >>>>>>>>>> * JIRA release notes [1], > > >>>>>>>>>> * the official Apache source release and binary convenience > > >>>>> releases > > >>>>>>>> to > > >>>>>>>>> be > > >>>>>>>>>> deployed to dist.apache.org [2], which are signed with the > > >>> key > > >>>>> with > > >>>>>>>>>> fingerprint FBB83C0A4FFB9CA8 [3], > > >>>>>>>>>> * all artifacts to be deployed to the Maven Central Repository > > >>>>> [4], > > >>>>>>>>>> * source code tag "release-1.12.5-rc3" [5], > > >>>>>>>>>> * website pull request listing the new release and adding > > >>>>>> announcement > > >>>>>>>>> blog > > >>>>>>>>>> post [6]. > > >>>>>>>>>> > > >>>>>>>>>> The vote will be open for at least 72 hours. It is adopted by > > >>>>>> majority > > >>>>>>>>>> approval, with at least 3 PMC affirmative votes. > > >>>>>>>>>> > > >>>>>>>>>> Best, > > >>>>>>>>>> Jingsong Lee > > >>>>>>>>>> > > >>>>>>>>>> [1] > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12350166 > > >>>>>>>>>> [2] > > >>>>> https://dist.apache.org/repos/dist/dev/flink/flink-1.12.5-rc3/ > > >>>>>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > >>>>>>>>>> [4] > > >>>>>>>>>> > > >>>>>>>> > > >>>>> > > >>> > > https://repository.apache.org/content/repositories/orgapacheflink-1440/ > > >>>>>>>>>> > > >>>>>>>> > > >>>>> > > >>> > > https://repository.apache.org/content/repositories/orgapacheflink-1441/ > > >>>>>>>>>> [5] > > >>>>> https://github.com/apache/flink/releases/tag/release-1.12.5-rc3 > > >>>>>>>>>> [6] https://github.com/apache/flink-web/pull/455 > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>>> > > >>>>> > > >>>>> > > >>>>> -- > > >>>>> Best, Jingsong Lee > > >>>>> > > >>>> > > >>> > > > > > > > >
