+1 (binding)
I had an offline chat with Fabian Paul about the mentioned changes.
The serializer changes should be acceptable as the migration would have
failed/stuck otherwise. At no point in time we end up with a corrupt
serializer snapshot. We will update older 1.14 release notes to point
out the upgrade shortcoming.
The transformation changes should also be fine. The same transformation
is returned. The type has changed but it is unlikely that user query the
output type of a sink?
Regards,
Timo
On 17.01.22 09:45, Timo Walther wrote:
I went through the commit diff and found the following changes that
might cause issues in my opinion. Maybe it makes sense to take a second
look before I will cast my vote:
// change of transformations
https://github.com/apache/flink/commit/b7cd97b02d7f39b5190d27fbaf6e6287f127b9a9
// change of a serializer
https://github.com/apache/flink/commit/564dee0752619ecb739b4bee1cacba856ea53bac
In any case, the following commits should be explicitly mentioned in the
release notes as they could cause issues during an upgrade from 1.14.2
(mostly SQL related because we don't have an upgrade story there yet):
https://github.com/apache/flink/commit/d3df986a75e34e1ed475b2e1236b7770698e7bd1
https://github.com/apache/flink/commit/3719c0402ec979c619371fcde9f2e7d2c46d69ed
https://github.com/apache/flink/commit/bafb0b4c2377d6d502ed9dba8853631ebf16cfb7
https://github.com/apache/flink/commit/309dc0479172b979ee3c951893a04304b5416a08
https://github.com/apache/flink/commit/7c5ddbd201005e55ab68b4db7ee74c7cbeb13400
Regards,
Timo
On 13.01.22 12:22, Xingbo Huang wrote:
+1 (non-binding)
- Verified checksums and signatures
- Verified Python wheel package contents
- Pip install apache-flink-libraries source package and apache-flink
wheel
package in Mac
- Run the examples from Python Table API Tutorial[1] in Python REPL
[1]
https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/python/table_api_tutorial/
Best,
Xingbo
Jingsong Li <jingsongl...@gmail.com> 于2022年1月13日周四 10:05写道：
+1 (non-binding)
- Verified checksums and signatures
- Build from source
- Start a standalone cluster, web is OK
- Start sql-client, everything looks good
Best,
Jingsong
On Wed, Jan 12, 2022 at 11:00 PM Till Rohrmann <trohrm...@apache.org>
wrote:
+1 (binding)
- Verified checksums and signatures
- Build from source and ran StateMachineExample
- Reviewed the flink-web PR
- Verified that there were no other dependency changes than
testcontainer,
japicmp-plugin and log4j.
Cheers,
Till
On Wed, Jan 12, 2022 at 9:58 AM Yun Tang <myas...@live.com> wrote:
+1 (non-binding)
* Checked the signature of source code, some of binaries and some
of
python packages.
* Launch a local cluster successfully on linux machine with
correct
flink-version and commit id and run the state machine example
successfully
as expected.
* Reviewed the flink-web PR.
Best
Yun Tang
________________________________
From: Martijn Visser <mart...@ververica.com>
Sent: Wednesday, January 12, 2022 0:34
To: dev <dev@flink.apache.org>
Subject: [VOTE] Release 1.14.3, release candidate #1
Hi everyone,
Please review and vote on the release candidate #1 for the version
1.14.3, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which
includes:
* JIRA release notes [1],
* the official Apache source release and binary convenience
releases to
be deployed to dist.apache.org [2], which are signed with the key with
fingerprint 12DEE3E4D920A98C [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "release-1.14.3-rc1" [5],
* website pull request listing the new release and adding announcement
blog post [6].
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks on behalf of Thomas Weise and myself,
Martijn Visser
http://twitter.com/MartijnVisser82
[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12351075&projectId=12315522
[2] https://dist.apache.org/repos/dist/dev/flink/flink-1.14.3-rc1/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4]
https://repository.apache.org/content/repositories/orgapacheflink-1481/
[5] https://dist.apache.org/repos/dist/dev/flink/flink-1.14.3-rc1/
[6] https://github.com/apache/flink-web/pull/497
