Probably, my expectations were wrong here: I expected that we want to test the compatibility in these tests between different major versions and that we would want to verify the current version of the release branch as well before releasing the artifacts. What's the rationale behind doing it after the artifacts are released?
On Fri, Sep 30, 2022 at 3:37 PM Chesnay Schepler <ches...@apache.org> wrote: > Could you be more specific as to what you believe should be updated? > > IIRC the release-1.16 branch only gets updated ta all once the release > is out (e.g., mark docs as stable, update japicmp reference). > > On 30/09/2022 15:32, Matthias Pohl wrote: > > Looking into the git history, there are numerous locations that need to > be > > updated in the release-1.16 branch. Yun Gao did a few commits around that > > topic (da9e6be..6f69f4e). But these changes were committed close to the > > actual release date rather than the release branch creation date. Is this > > part of the release steps [1]. It feels like it should be part of the > > section where we create the release branch. But cannot find the pointer. > > > > [1] > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release > > > > On Fri, Sep 30, 2022 at 2:47 PM Matthias Pohl <matthias.p...@aiven.io> > > wrote: > > > >> -1 (non-binding) > >> > >> Hi Xingbo, > >> I just noticed that we haven't updated the current Flink version in > >> TypeSerializerUpgradeTest. It is missing in the release-1.16 branch and > on > >> master. That means that the serialization tests are not executed for > Flink > >> 1.16. See FLINK-29485 [1]. > >> > >> [1] https://issues.apache.org/jira/browse/FLINK-29485 > >> > >> On Fri, Sep 30, 2022 at 11:28 AM Xingbo Huang <h...@apache.org> wrote: > >> > >>> Hi everyone, > >>> > >>> Please review and vote on the release candidate #1 for the version > 1.16.0, > >>> as follows: > >>> [ ] +1, Approve the release > >>> [ ] -1, Do not approve the release (please provide specific comments) > >>> > >>> The complete staging area is available for your review, which includes: > >>> * JIRA release notes [1], > >>> * the official Apache source release and binary convenience releases > to be > >>> deployed to dist.apache.org [2], which are signed with the key with > >>> fingerprint 3C2C9FFB59DF9F3E [3], > >>> * all artifacts to be deployed to the Maven Central Repository [4], > >>> * source code tag "release-1.16.0-rc1" [5], > >>> * website pull request listing the new release and adding announcement > >>> blog > >>> post [6]. > >>> > >>> The vote will be open for at least 72 hours. It is adopted by majority > >>> approval, with at least 3 PMC affirmative votes. > >>> > >>> Thanks, > >>> Chesnay, Martijn, Godfrey & Xingbo > >>> > >>> [1] > >>> > >>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351275 > >>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.16.0-rc1 > >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>> [4] > >>> https://repository.apache.org/content/repositories/orgapacheflink-1537 > >>> [5] https://github.com/apache/flink/tree/release-1.16.0-rc1 > >>> [6] https://github.com/apache/flink-web/pull/574 > >>> > >
