Hi all, Peter, Marton, Gordon and I had an offline sync on SinkV2 and I'm happy with this first FLIP on the topic. +1
Best regards, Martijn On Wed, Oct 4, 2023 at 5:48 PM Márton Balassi <balassi.mar...@gmail.com> wrote: > > Thanks, Peter. I agree that this is needed for Iceberg and beneficial for > other connectors too. > > +1 > > On Wed, Oct 4, 2023 at 3:56 PM Péter Váry <peter.vary.apa...@gmail.com> > wrote: > > > Hi Team, > > > > In my previous email[1] I have described our challenges migrating the > > existing Iceberg SinkFunction based implementation, to the new SinkV2 based > > implementation. > > > > As a result of the discussion around that topic, I have created the first > > [2] of the FLIP-s addressing the missing features there. > > > > The main goal of the FLIP-371 is to extend the currently existing Committer > > API by providing an initial context on Committer creation. This context > > will contain - among other, less interesting data - > > the SinkCommitterMetricGroup which could be used to store the generic > > commit related metrics, and also provide a way for the Committer to publish > > its own metrics. > > > > The feature has already been requested through FLINK-25857 [3]. > > > > Please use this thread to discuss the FLIP related questions, proposals, > > feedback. > > > > Thanks, > > Peter > > > > - [1] https://lists.apache.org/thread/h3kg7jcgjstpvwlhnofq093vk93ylgsn > > - [2] > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-371%3A+SinkV2+Committer+imporvements > > - [3] https://issues.apache.org/jira/browse/FLINK-25857 > >
