Hi folks, In the release managers' sync-up meeting today, we have discussed all issues and came to a consensus that there are no blocking issues for 1.18 release. Since there were some new commits after rc1, I will create a rc2 now. Thanks again for your contributions.
Best regards, Jing On Mon, Oct 9, 2023 at 12:10 PM Sergey Nuyanzin <snuyan...@gmail.com> wrote: > Hi Jing, > > Thanks for looking into this > > I checked it against opensearch connector [1] and it is green now > Also checked against hbase [2] which is now failing because of a different > issue > however anyway it was able to go further (before it failed at Download > Flink binary task) than when it was not publicly accessible. > Also a had a look at kafka connector [3] where Download Flink binary task > is also completed > Thus i don't see a connector where Download Flink binary is failing, so i > would consider this as resolved > > At the same time there is another issue which was mentioned above [4]. It > looks like there were some changes in 1.18.0 like [5], [6] which > potentially could result in this issue > Shouldn't we consider it as a blocker? > > [1] > > https://github.com/apache/flink-connector-opensearch/actions/runs/6312803412?pr=32 > [2] > > https://github.com/apache/flink-connector-hbase/actions/runs/6210320267/job/17518738266 > [3] > > https://github.com/apache/flink-connector-kafka/actions/runs/6453974340/job/17518572643 > [4] https://issues.apache.org/jira/browse/FLINK-33186 > [5] https://issues.apache.org/jira/browse/FLINK-32996 > [6] https://issues.apache.org/jira/browse/FLINK-32907 > > > On Mon, Oct 9, 2023 at 10:06 AM Jing Ge <j...@ververica.com.invalid> > wrote: > > > Hi Folks, > > > > Ververica has made the files publicly accessible. Could anyone check if > any > > connector build works again? > > > > Best regards, > > Jing > > > > On Mon, Oct 9, 2023 at 9:07 AM Jing Ge <j...@ververica.com> wrote: > > > > > Hi Sergey and devs, > > > > > > Thanks for bringing this to our attention. I am open to discuss that. I > > > have the following thoughts: > > > > > > 1. Like I already mentioned in many other threads, build issues in > > > downstream repos should not block upstream release. I understand the > > > concern that developers want to have stable connectors. But it violates > > the > > > intention of connector externalization. > > > 2. It is expensive to download Flink jar(roughly 500M) from S3 for each > > PR > > > and nightly build of each connector. Does it make sense to leverage > [1]. > > > Many Flink docs have been using it. > > > 3. I will check internally at Ververica to see if we could make the > file > > > publicly accessible to temporarily solve this issue. > > > > > > Looking forward to your feedback. > > > > > > Best regards, > > > Jing > > > > > > [1] https://nightlies.apache.org/flink/ > > > > > > On Fri, Oct 6, 2023 at 2:03 PM Konstantin Knauf <kna...@apache.org> > > wrote: > > > > > >> Hi everyone, > > >> > > >> I've just opened a PR for the release announcement [1] and I am > looking > > >> forward to reviews and feedback. > > >> > > >> Cheers, > > >> > > >> Konstantin > > >> > > >> [1] https://github.com/apache/flink-web/pull/680 > > >> > > >> Am Fr., 6. Okt. 2023 um 11:03 Uhr schrieb Sergey Nuyanzin < > > >> snuyan...@gmail.com>: > > >> > > >> > sorry for not mentioning it in previous mail > > >> > > > >> > based on the reason above I'm > > >> > -1 (non-binding) > > >> > > > >> > also there is one more issue [1] > > >> > which blocks all the externalised connectors testing against the > most > > >> > recent commits in > > >> > to corresponding branches > > >> > [1] https://issues.apache.org/jira/browse/FLINK-33175 > > >> > > > >> > > > >> > On Thu, Oct 5, 2023 at 11:19 PM Sergey Nuyanzin < > snuyan...@gmail.com> > > >> > wrote: > > >> > > > >> > > Thanks for creating RC1 > > >> > > > > >> > > * Downloaded artifacts > > >> > > * Built from sources > > >> > > * Verified checksums and gpg signatures > > >> > > * Verified versions in pom files > > >> > > * Checked NOTICE, LICENSE files > > >> > > > > >> > > The strange thing I faced is > > >> > > > > >> > CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished > > >> > > fails on AZP [1] > > >> > > > > >> > > which looks like it is related to [2], [3] fixed in 1.18.0 (not > > 100% > > >> > > sure). > > >> > > > > >> > > > > >> > > [1] https://issues.apache.org/jira/browse/FLINK-33186 > > >> > > [2] https://issues.apache.org/jira/browse/FLINK-32996 > > >> > > [3] https://issues.apache.org/jira/browse/FLINK-32907 > > >> > > > > >> > > On Tue, Oct 3, 2023 at 2:53 PM Ferenc Csaky > > >> <ferenc.cs...@pm.me.invalid> > > >> > > wrote: > > >> > > > > >> > >> Thanks everyone for the efforts! > > >> > >> > > >> > >> Checked the following: > > >> > >> > > >> > >> - Downloaded artifacts > > >> > >> - Built Flink from source > > >> > >> - Verified checksums/signatures > > >> > >> - Verified NOTICE, LICENSE files > > >> > >> - Deployed dummy SELECT job via SQL gateway on standalone > cluster, > > >> > things > > >> > >> seemed fine according to the log files > > >> > >> > > >> > >> +1 (non-binding) > > >> > >> > > >> > >> Best, > > >> > >> Ferenc > > >> > >> > > >> > >> > > >> > >> ------- Original Message ------- > > >> > >> On Friday, September 29th, 2023 at 22:12, Gabor Somogyi < > > >> > >> gabor.g.somo...@gmail.com> wrote: > > >> > >> > > >> > >> > > >> > >> > > > >> > >> > > > >> > >> > Thanks for the efforts! > > >> > >> > > > >> > >> > +1 (non-binding) > > >> > >> > > > >> > >> > * Verified versions in the poms > > >> > >> > * Built from source > > >> > >> > * Verified checksums and signatures > > >> > >> > * Started basic workloads with kubernetes operator > > >> > >> > * Verified NOTICE and LICENSE files > > >> > >> > > > >> > >> > G > > >> > >> > > > >> > >> > On Fri, Sep 29, 2023, 18:16 Matthias Pohl > > >> > matthias.p...@aiven.io.invalid > > >> > >> > > > >> > >> > wrote: > > >> > >> > > > >> > >> > > Thanks for creating RC1. I did the following checks: > > >> > >> > > > > >> > >> > > * Downloaded artifacts > > >> > >> > > * Built Flink from sources > > >> > >> > > * Verified SHA512 checksums GPG signatures > > >> > >> > > * Compared checkout with provided sources > > >> > >> > > * Verified pom file versions > > >> > >> > > * Went over NOTICE file/pom files changes without finding > > >> anything > > >> > >> > > suspicious > > >> > >> > > * Deployed standalone session cluster and ran WordCount > example > > >> in > > >> > >> batch > > >> > >> > > and streaming: Nothing suspicious in log files found > > >> > >> > > > > >> > >> > > +1 (binding) > > >> > >> > > > > >> > >> > > On Fri, Sep 29, 2023 at 10:34 AM Etienne Chauchot > > >> > >> echauc...@apache.org > > >> > >> > > wrote: > > >> > >> > > > > >> > >> > > > Hi all, > > >> > >> > > > > > >> > >> > > > Thanks to the team for this RC. > > >> > >> > > > > > >> > >> > > > I did a quick check of this RC against user pipelines (1) > > coded > > >> > with > > >> > >> > > > DataSet (even if deprecated and soon removed), DataStream > and > > >> SQL > > >> > >> APIs > > >> > >> > > > > > >> > >> > > > based on the small scope of this test, LGTM > > >> > >> > > > > > >> > >> > > > +1 (non-binding) > > >> > >> > > > > > >> > >> > > > [1] https://github.com/echauchot/tpcds-benchmark-flink > > >> > >> > > > > > >> > >> > > > Best > > >> > >> > > > Etienne > > >> > >> > > > > > >> > >> > > > Le 28/09/2023 à 19:35, Jing Ge a écrit : > > >> > >> > > > > > >> > >> > > > > Hi everyone, > > >> > >> > > > > > > >> > >> > > > > The RC1 for Apache Flink 1.18.0 has been created. The > > related > > >> > >> voting > > >> > >> > > > > process will be triggered once the announcement is ready. > > The > > >> > RC1 > > >> > >> has > > >> > >> > > > > all > > >> > >> > > > > the artifacts that we would typically have for a release, > > >> except > > >> > >> for > > >> > >> > > > > the > > >> > >> > > > > release note and the website pull request for the release > > >> > >> announcement. > > >> > >> > > > > > > >> > >> > > > > The following contents are available for your review: > > >> > >> > > > > > > >> > >> > > > > - Confirmation of no benchmarks regression at the > > thread[1]. > > >> > >> > > > > - The preview source release and binary convenience > > releases > > >> > [2], > > >> > >> which > > >> > >> > > > > are signed with the key with fingerprint > > 96AE0E32CBE6E0753CE6 > > >> > [3]. > > >> > >> > > > > - all artifacts that would normally be deployed to the > > Maven > > >> > >> > > > > Central Repository [4]. > > >> > >> > > > > - source code tag "release-1.18.0-rc1" [5] > > >> > >> > > > > > > >> > >> > > > > Your help testing the release will be greatly > appreciated! > > >> And > > >> > >> we'll > > >> > >> > > > > create the rc1 release and the voting thread as soon as > all > > >> the > > >> > >> efforts > > >> > >> > > > > are > > >> > >> > > > > finished. > > >> > >> > > > > > > >> > >> > > > > [1] > > >> > >> https://lists.apache.org/thread/yxyphglwwvq57wcqlfrnk3qo9t3sr2ro > > >> > >> > > > > [2] > > >> > https://dist.apache.org/repos/dist/dev/flink/flink-1.18.0-rc1/ > > >> > >> > > > > [3]https://dist.apache.org/repos/dist/release/flink/KEYS > > >> > >> > > > > [4] > > >> > >> > > > > > > >> > >> > > >> > https://repository.apache.org/content/repositories/orgapacheflink-1657 > > >> > >> > > > > [5] > > >> > >> https://github.com/apache/flink/releases/tag/release-1.18.0-rc1 > > >> > >> > > > > > > >> > >> > > > > Best regards, > > >> > >> > > > > Qingsheng, Sergei, Konstantin and Jing > > >> > >> > > >> > > > > >> > > > > >> > > -- > > >> > > Best regards, > > >> > > Sergey > > >> > > > > >> > > > >> > > > >> > -- > > >> > Best regards, > > >> > Sergey > > >> > > > >> > > >> > > >> -- > > >> https://twitter.com/snntrable > > >> https://github.com/knaufk > > >> > > > > > > > > -- > Best regards, > Sergey >
