Hi, I had a 3 of comments: - the name of the config option is "scan.filter-push-down.enabled". This implies it is only for scan sources and not lookups. I suggest removing the scan. prefix. - there is a talk of having a numeric option, as the filter pushdown might result in a full table scan. Without the filter being pushed down - I assume there will be a full table scan anyway - how is the filter pushdown full table scan worse than the full table scan that will occur without it. - what are the use cases to not pushdown filters if the source supports it. The only one I can think of is that during development , you can easily compare query results between pushed down filters and not - to check they are the same. Are there other cases?
On 2023/10/24 14:13:38 Jiabao Sun wrote: > Thanks Jark, Martijn, Xuyang for the valuable feedback. > > Adding only the "scan.filter-push-down.enabled" configuration option would be > great for me as well. > Optimization for this public behavior can be added later. > > I made some modifications to the FLIP document and added the approach of > adding new method to the Rejected Alternatives section. > > Looking forward to your feedback again. > > Best, > Jiabao > > > > 2023年10月24日 16:58，Jark Wu <imj...@gmail.com> 写道： > > > > the current interface can already satisfy your requirements. > > The connector can reject all the filters by returning the input filters > > as `Result#remainingFilters`. > >
