----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6316/#review9745 -----------------------------------------------------------
The INFO Hadoop setting is certainly needed. Also, including the thread name is great. However I have heard that DailyRollingFileAppender is unreliable and can cause data loss at roll time. What's the reason behind that change? - Mike Percy On Aug. 2, 2012, 7 a.m., Denny Ye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6316/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2012, 7 a.m.) > > > Review request for Flume and Hari Shreedharan. > > > Description > ------- > > Updated log4j.properties > 1. Add 'logs' folder. It's better to aggregate logs into unified folder. > 2. Log file using DailyRollingFileAppender > 3. More useful log pattern. Add thread and code line information > 4. Set debug level for Hadoop. If we use debug level, Hadoop log takes too > many lines. > > > This addresses bug https://issues.apache.org/jira/browse/FLUME-1418. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1418 > > > Diffs > ----- > > trunk/conf/log4j.properties 1363210 > > Diff: https://reviews.apache.org/r/6316/diff/ > > > Testing > ------- > > That's OK in my environment > > > Thanks, > > Denny Ye > >
