-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6316/#review9937
-----------------------------------------------------------

Ship it!


+1

- Mike Percy


On Aug. 7, 2012, 2:19 a.m., Denny Ye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6316/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 2:19 a.m.)
> 
> 
> Review request for Flume and Hari Shreedharan.
> 
> 
> Description
> -------
> 
> Updated log4j.properties 
> 1. Add 'logs' folder. It's better to aggregate logs into unified folder.
> 2. Log file using DailyRollingFileAppender
> 3. More useful log pattern. Add thread and code line information
> 4. Set debug level for Hadoop. If we use debug level, Hadoop log takes too 
> many lines.
> 
> 
> This addresses bug FLUME-1418.
>     https://issues.apache.org/jira/browse/FLUME-1418
> 
> 
> Diffs
> -----
> 
>   trunk/conf/log4j.properties 1363210 
> 
> Diff: https://reviews.apache.org/r/6316/diff/
> 
> 
> Testing
> -------
> 
> That's OK in my environment
> 
> 
> Thanks,
> 
> Denny Ye
> 
>

Reply via email to